Re: [OpenStack-Infra] proposed change to git-review to better support https connections

2015-02-25 Thread Diego Garcia del Rio
Thanks. Let me know if it makes sense for me to push those changes upstream. I was not aware of the git credentials helper... I know git-review is an infra project and thus not touched too much since everyone uses it... Best Regards, On Wed, Feb 25, 2015 at 5:06 PM, Clark Boylan

Re: [OpenStack-Infra] proposed change to git-review to better support https connections

2015-02-25 Thread Clark Boylan
I see what you mean about defaulting the port now. I think having the port default to 443 when scheme is HTTPS would be a good improvement to git review. For password handling its probably best for users to use the git credential helper [0] instead of having git review try to be smart with that

Re: [OpenStack-Infra] proposed change to git-review to better support https connections

2015-02-25 Thread Diego Garcia del Rio
This would be the page https://wiki.openstack.org/wiki/Gerrit_Workflow , in particular the section called Accessing Gerrit over HTTPS I think i still need to catch up on the automated infrastructure testing as well. Thanks! On Wed, Feb 25, 2015 at 4:39 PM, Clark Boylan

Re: [OpenStack-Infra] proposed change to git-review to better support https connections

2015-02-25 Thread Clark Boylan
On Wed, Feb 25, 2015, at 04:23 PM, Diego Garcia del Rio wrote: Hi, I'm pretty new to contributing code to openstack, but I had ran into some issues trying to push changes to gerrit using the HTTPS option. (In particular, added the ability to save your HTTP password into the git config and

Re: [OpenStack-Infra] Cross-Repo Dependencies in Zuul

2015-02-25 Thread Andreas Jaeger
On 02/12/2015 05:58 PM, Anita Kuno wrote: On 02/12/2015 03:42 AM, Antoine Musso wrote: Le 10/02/2015 23:26, James E. Blair a écrit : We have added support for cross-repo dependencies (CRD) in Zuul. Hello James and Infra, Congratulations for this nice feature, that is a great addition