Re: [OpenStack-Infra] [openstack-dev] Upcoming changes now that Jenkins has retired

2016-06-19 Thread Will Zhou
Hi Jim, Thanks for the explanation. On Fri, Jun 17, 2016 at 6:01 PM Joshua Hesketh wrote: > We can update those without any trouble. We just need to also update the > tests that check the usernames. You should be able to make all of the > changes (as per your first

Re: [OpenStack-Infra] [openstack-dev] Upcoming changes now that Jenkins has retired

2016-06-17 Thread Joshua Hesketh
We can update those without any trouble. We just need to also update the tests that check the usernames. You should be able to make all of the changes (as per your first patchset) and then find where the tests also need changing. Happy to help you on the review if you need more guidance. To

Re: [OpenStack-Infra] [openstack-dev] Upcoming changes now that Jenkins has retired

2016-06-17 Thread Will Zhou
Hi James, I submitted a fix to openstack-infra/zuul via https://review.openstack.org/#/c/330853/. I found that username could not be changed from 'jenkins' to 'zuul' like https://github.com/openstack-infra/zuul/blob/master/tests/fixtures/layouts/good_require_approvals.yaml#L11 review_gerrit: -