I accidentally didn't reply to the list earlier, so forwarding this through for completeness. I agree with the proposal/discussion in general.
---------- Forwarded message ---------- From: Joshua Hesketh <joshua.hesk...@gmail.com> Date: Thu, May 25, 2017 at 3:53 PM Subject: Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax To: Jeremy Stanley <fu...@yuggoth.org> On Thu, May 25, 2017 at 10:55 AM, Jeremy Stanley <fu...@yuggoth.org> wrote: > On 2017-05-25 00:33:10 +0000 (+0000), Tristan Cacqueray wrote: > > On May 24, 2017 11:04 pm, James E. Blair wrote: > > [...] > > >How does that sound? > > > > Thinking about further connections support, could this also works > > for a (theorical) mail based patch cross dependency? > > I can imagine wanting something like: > > Depends-On: https://lkml.org/lkml/diff/2017/5/24/668/1 > > ...where zuul will git am what it finds there. > > > What's the logic to match the Depends-On syntax to a connection > > driver? > > This brings up an additional question: how far can we stretch the > concept of a connection driver, and does it always need to be > something we can report back on in some way? Maybe we want to test a > Gerrit change or GutHub PR which requires a patch from the LKML (as > above) when rebuilding the kernel for a guest, but we don't ever > expect to report back to the LKML about anything. Would having a > generic HTTP(S) driver for things like this make sense? > We already have a generic git driver so it'll be theoretically possible to point at a git ref in the future. We could also look at having a patch/diff driver. Depends-On, while used to set up testing scenarios, also adds a restriction of "only merge after XYZ". We could assume that a dependency on a git ref has already merged (and it is there to simply instruct the test/build), but I'm not sure if a "Depends-On diff" makes as much sense. How do we know when the diff has been applied? I don't really want to introduce extra complexity, but one option could be to have "Test-With" (for merging in the test suit) and "Depends-On" (for blocking until merged) as separate DSL. My gut feeling is that covering an arbitrary git ref is probably good enough for now along with the assumption that anything from the git driver has already merged. Cheers, Josh > -- > Jeremy Stanley > > _______________________________________________ > OpenStack-Infra mailing list > OpenStack-Infra@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra >
_______________________________________________ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
