Re: [OpenStack-Infra] Fwd: JJB 1.6.0 "Cannot create a file when that file already exists"

2016-06-09 Thread Sebastian Schuberth
On Thu, Jun 9, 2016 at 4:48 PM, Jeremy Stanley wrote: >> I've done the change myself, please review: >> https://review.openstack.org/327539 >> >> I decided to catch the exception instead of always deleting the dst >> file first to keep it being an atomic operation on Unix. > > That seems to have

Re: [OpenStack-Infra] Fwd: JJB 1.6.0 "Cannot create a file when that file already exists"

2016-06-09 Thread Jeremy Stanley
On 2016-06-09 11:39:28 +0200 (+0200), Sebastian Schuberth wrote: > I've done the change myself, please review: > https://review.openstack.org/327539 > > I decided to catch the exception instead of always deleting the dst > file first to keep it being an atomic operation on Unix. That seems to hav

Re: [OpenStack-Infra] Fwd: JJB 1.6.0 "Cannot create a file when that file already exists"

2016-06-09 Thread Sebastian Schuberth
I've done the change myself, please review: https://review.openstack.org/327539 I decided to catch the exception instead of always deleting the dst file first to keep it being an atomic operation on Unix. -- Sebastian Schuberth On Thu, Jun 9, 2016 at 7:01 AM, Sebastian Schuberth wrote: > Hi

Re: [OpenStack-Infra] Fwd: JJB 1.6.0 "Cannot create a file when that file already exists"

2016-06-08 Thread Sebastian Schuberth
Hi Darragh, are you going to make that change in Gerrit? -- Sebastian Schuberth On Thu, Jun 9, 2016 at 12:52 AM, Darragh Bailey wrote: > Doh! It's called not using windows enough. > > The os.rename() it appears throws an error on windows if the target file > exists. > > We need to catch th

Re: [OpenStack-Infra] Fwd: JJB 1.6.0 "Cannot create a file when that file already exists"

2016-06-08 Thread Darragh Bailey
Doh! It's called not using windows enough. The os.rename() it appears throws an error on windows if the target file exists. We need to catch that and remove the file, then retry, or remove the old file first. The fun of cross platform. Sorry about that. Darragh Bailey "Nothing is foolproof

[OpenStack-Infra] Fwd: JJB 1.6.0 "Cannot create a file when that file already exists"

2016-06-08 Thread Sebastian Schuberth
Hi, since upgrading to JJB 1.6.0 from 1.5.0 today I consistently get "Cannot create a file when that file already exists" errors on update / delete operations on Windows. The stack trace looks like $ jenkins-jobs delete github-checker.yaml INFO:jenkins_jobs.builder:Removing jenkins job(s): github