[OpenStack-Infra] check pipeline triggered when comments are added

2014-03-04 Thread Antoine Musso
Hello, For a couple weeks I noticed the Zuul 'check' pipeline is being triggered when adding a single comment on an old patch. I find it annoying when a patchset review takes a couple weeks or so. The review would usually lead to a new patchset and I don't think the intermediary checks are

Re: [OpenStack-Infra] check pipeline triggered when comments are added

2014-03-04 Thread Michael Still
Yes. Patches with very old checks were hitting the merge pipeline, where their failure was very expensive. Instead, they get rechecked every few days to ensure the author knows when the patch has zero chance of merging. Michael On Tue, Mar 4, 2014 at 8:31 PM, Antoine Musso has...@free.fr wrote:

Re: [OpenStack-Infra] check pipeline triggered when comments are added

2014-03-04 Thread Sean Dague
Correct, when we did the analysis of the giant back up in Feb, a very large number of the gate resets were caused by people pushing old patches in that could not pass tests. People would +A patches that had test results that were 6 weeks old. I didn't do careful analysis here, but based on the

Re: [OpenStack-Infra] check pipeline triggered when comments are added

2014-03-04 Thread Joshua Hesketh
Rackspace Australia On 3/5/14 2:39 AM, James E. Blair wrote: Antoine Musso has...@free.fr writes: Hello, For a couple weeks I noticed the Zuul 'check' pipeline is being triggered when adding a single comment on an old patch. I find it annoying when a patchset review takes a couple weeks or