Re: [OpenStack-Infra] vcsrepo upstream

2015-09-24 Thread Spencer Krum
I've created https://github.com/puppet-community/puppet-git_resource/pull/12 to rectify the issue with git_resource. Note that the autorequires there isn't really a critical bug, it will require the class if it exists, but do nothing if the class does not exist. On Thu, Sep 24, 2015 at 1:31 AM, M

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-24 Thread Marton Kiss
+1 to git_resource module. Anyway it needs some care to fix issues, and it is a bit more then documentation things. For example this direct dependency on a non-existent git class: https://github.com/puppet-community/puppet-git_resource/blob/master/lib/puppet/type/git.rb#L86 The git class was inclu

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-23 Thread Spencer Krum
My preference is to use the puppet-community-git_resource module, it provides an easy way to transition and can be opinionated about the git functionality we want. I've heard from many people that the module only supports redhat, which isn't true. But I think we should view that as a documentation

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-23 Thread Marton Kiss
I hope we can fix that refresh issue within a reasonable timeframe, and this change won't affect the new releases of production ask.o.o. M. On Wed, Sep 23, 2015 at 4:56 PM Jeremy Stanley wrote: > On 2015-09-23 12:19:22 + (+), Marton Kiss wrote: > > Yeah, this temporary fix solves the go

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-23 Thread Jeremy Stanley
On 2015-09-23 12:19:22 + (+), Marton Kiss wrote: > Yeah, this temporary fix solves the going offline thingy: > https://review.openstack.org/#/c/222653/ > > Sitting in the queue for a while, a +2 approval could help to stop refresh > triggers on ask.o.o As a very temporary measure I've app

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-23 Thread Marton Kiss
Yeah, this temporary fix solves the going offline thingy: https://review.openstack.org/#/c/222653/ Sitting in the queue for a while, a +2 approval could help to stop refresh triggers on ask.o.o M. On Wed, Sep 23, 2015 at 2:12 PM Jeremy Stanley wrote: > On 2015-09-23 07:40:38 + (+), Mar

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-23 Thread Jeremy Stanley
On 2015-09-23 07:40:38 + (+), Marton Kiss wrote: [...] > So my personal opinion that this workaround not solves our > original problem of refresh event triggers, basically it is > working, but totally hiding relevant information, and makes later > debugging or problem discovery impossible.

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-23 Thread Marton Kiss
I was playing with an alternative workaround, where the askbot exec resources extended with a conditional check of git HEAD status. I made a quick poc, you can find it here: https://github.com/mkissam/puppet-vcsrepo-refresh-poc/blob/master/vcsrepo-refresh-workaround.md The test results are the fol

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-16 Thread Marton Kiss
Colleen, Thank you for the infos, sowe have three options now, and - openstack-infra/puppet-vcsrepo requires a patch backport - puppet-community/puppet-git_resource require some extra work - upstream puppet-vcsrepo: what are the arguments against that? M. On Wed, Sep 16, 2015 at 8:23 PM Colleen

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-16 Thread Colleen Murphy
On Wed, Sep 16, 2015 at 11:12 AM, Marton Kiss wrote: > Hi Colleen, > > Have you ever tried this puppet-community puppet-git_resource module? It > seems to be that it is not ready, the resource auto-depends on a git class > here: > > https://github.com/puppet-community/puppet-git_resource/blob/04e

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-16 Thread Marton Kiss
Hi Colleen, Have you ever tried this puppet-community puppet-git_resource module? It seems to be that it is not ready, the resource auto-depends on a git class here: https://github.com/puppet-community/puppet-git_resource/blob/04ec35488c4d0d5374c736daa4a7e89fbf3e8d84/lib/puppet/type/git.rb#L86 bu

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-16 Thread Marton Kiss
Thanks, I'll retry from this puppet-community repo. Brgds, Marton On Wed, Sep 16, 2015 at 6:01 PM Colleen Murphy wrote: > On Wed, Sep 16, 2015 at 2:00 AM, Marton Kiss > wrote: > > >> It have RedHat support only >> > > > It supports Ubuntu as well. The git class, which only supports RedHat,

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-16 Thread Colleen Murphy
On Wed, Sep 16, 2015 at 2:00 AM, Marton Kiss wrote: > It have RedHat support only > It supports Ubuntu as well. The git class, which only supports RedHat, just installs git from repoforge. On Ubuntu we would just manage this with a package resource. The git resource, which is the replacement f

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-16 Thread Marton Kiss
The git puppet module requires some additional work, not looks stable for me. It have RedHat support only, and it won't work for askbot, because those instances based on Ubuntu 14.04LTS actually. I guess we need a stable solution within a reasonable timeframe. Git puppet should evolve, but I see no

Re: [OpenStack-Infra] vcsrepo upstream

2015-09-15 Thread Paul Belanger
On Tue, Sep 15, 2015 at 06:09:45PM +, Marton Kiss wrote: > Dear all, > > Actually openstack-infra/system-config is using the > openstack-infra/puppet-vcsrepo module for handling git repositories. > > With Jeremy and Clark we found an issue related this vcsrepo module which > is a fork of orig

[OpenStack-Infra] vcsrepo upstream

2015-09-15 Thread Marton Kiss
Dear all, Actually openstack-infra/system-config is using the openstack-infra/puppet-vcsrepo module for handling git repositories. With Jeremy and Clark we found an issue related this vcsrepo module which is a fork of original puppetlabs-vcsrepo, but not follow the upstream. I made a little poc t