Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread Daryl Walleck
What I'm saying is that wait_for_server_status is just a function that, at least at the moment, has no concept of this state machine. Coding in a whitelist of good states may be confusing/frustrating as the different projects are expanded. Unless you know to add in a good state for feature X tha

Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread David Kranz
I am not sure what you mean. I meant that the status argument of wait_for_server_status should be an enum type, whether that be an actual enum type or an allowed set of strings. It should be a static type error, or at least as close as we can come, to pass a value that always means a coding err

Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread Daryl Walleck
I'm not sure I agree with causing a failure based on what the user inputs to a function. I feel like this is something we should enforce through standards and not in code. Daryl On Jun 18, 2012, at 12:34 PM, David Kranz wrote: > On 6/18/2012 1:07 PM, Jay Pipes wrote: >> On 06/18/2012 12:49 PM,

Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread David Kranz
On 6/18/2012 1:07 PM, Jay Pipes wrote: On 06/18/2012 12:49 PM, Daryl Walleck wrote: I can verify that rescue is a non-race state. The transition is active to rescue on setting rescue, and rescue to active when leaving rescue. I don't see a RESCUE state. I see a RESCUED state. Is that what you

Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread Jay Pipes
make sure, since the semantics and tenses of the power, VM, and task states are a bit inconsistent. Best, -jay Original message Subject: Re: [Openstack-qa-team] wait_for_server_status and Compute API From: Jay Pipes To: "openstack-qa-team@lists.launchpad.net

Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread Daryl Walleck
I can verify that rescue is a non-race state. The transition is active to rescue on setting rescue, and rescue to active when leaving rescue. Original message Subject: Re: [Openstack-qa-team] wait_for_server_status and Compute API From: Jay Pipes To: "openstack-qa

Re: [Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread Jay Pipes
On 06/18/2012 12:01 PM, David Kranz wrote: There are a few tempest tests, and many in the old kong suite that is still there, that wait for a server status that is something other than ACTIVE or VERIFY_RESIZE. These other states, such as BUILD or REBOOT, are transient so I don't understand why it

[Openstack-qa-team] wait_for_server_status and Compute API

2012-06-18 Thread David Kranz
There are a few tempest tests, and many in the old kong suite that is still there, that wait for a server status that is something other than ACTIVE or VERIFY_RESIZE. These other states, such as BUILD or REBOOT, are transient so I don't understand why it is correct for code to poll for those st