Re: [Openvpn-devel] [PATCH-fixed] revocation

2010-04-22 Thread Davide Brini
On Thursday 22 April 2010, Jan Just Keijser wrote: > > The only doubt I have is about error handling; in this case, if the > > allocation of the BIO fails, an error message is logged and nothing is > > done. Is this the right thing to do? > > I don't know if a FATAL error is such a good thing -

Re: [Openvpn-devel] [PATCH-fixed] revocation

2010-04-22 Thread Jan Just Keijser
Davide Brini wrote: On Thursday 22 April 2010, Davide Brini wrote: (moving to -devel as this is obviously pertains there more than -users) Sorry, too quick! I posted an incomplete version of the patch. The attached one should be better. The only doubt I have is about error

[Openvpn-devel] [PATCH] revocation

2010-04-22 Thread Davide Brini
(moving to -devel as this is obviously pertains there more than -users) On Thursday 22 April 2010, Davide Brini wrote: > > > RFC 5280 says that "certificate users MUST be able to handle > > > serialNumber values up to 20 octets", so a 16-byte value looks valid to > > > me. I would say (without

[Openvpn-devel] OpenVPN 2.1.1 and "inactive". "ping" is retrigger the inactivity timeout!!

2010-04-22 Thread Siegfried Müller - MB Connect Line GmbH
Hi developers, does anyone tried the "inactive" option with the openvpn version 2.1.1? I step up from 2.0.1 to 2.1.1 and get the problem, that the client does not disconnect after inactivity. If i set the option "ping 0" instead of "ping 10" the inactivity works. Could that be a problem, that

Re: [Openvpn-devel] [PATCH] Add comile time settings from ./configure to --version

2010-04-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13/04/10 15:49, David Sommerseth wrote: [...snip...] > > I've attached three patches, which cleans up this feature further. > This is an enhanced patch, based on review comments from Gert Doering. He mentioned that the configure_log.awk could be

[Openvpn-devel] ESET Smart Security interferes with TAP driver install

2010-04-22 Thread James Yonan
I've observed a case on Windows Server 2008R2 where an antivirus product called ESET Smart Security prevents install of the TAP driver. The net effect in tapinstall (devcon) is that UpdateDriverForPlugAndPlayDevices returns error code 1450 (ERROR_NO_SYSTEM_RESOURCES). Apparently ESET

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/04/10 10:15, Davide Brini wrote: > On Thursday 22 Apr 2010 09:02:23 David Sommerseth wrote: > >> For future patches, would you mind adding a little bit more descriptive >> text which can be used as commit log messages. I do write those commit

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread Davide Brini
On Thursday 22 Apr 2010 09:02:23 David Sommerseth wrote: > For future patches, would you mind adding a little bit more descriptive > text which can be used as commit log messages. I do write those commit > logs when I find it is needed, but adding a little bit more descriptions > of what the

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

2010-04-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19/04/10 23:37, Davide Brini wrote: > On Monday 19 April 2010, David Sommerseth wrote: > >> I've done a quick test on one of my connections on Fedora 12 without any >> resolvconf package (meaning it invokes the simple cp approach), and it >>