Re: [Openvpn-devel] [TESTING NEEDED] Using --inactive and --ping seems to defeat each other

2010-05-01 Thread Davide Brini
On Friday 30 April 2010, Davide Brini wrote: > Well, the obvious (and probably wrong, probably inefficient) way could > be to just check if the packet at hand is a ping message, and if it is > do not record it as "activity", eg > > if (! is_ping_msg (&c->c2.buf)) >register_activity (c, size);

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-01 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/05/10 08:18, Brian Raderman wrote: > Hi David, > > Thank you for taking a look at the patch and providing such thorough feedback > so > quickly. You're welcome! I'm happy to see you updating the patch and bringing it one step closer for incl

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-01 Thread Toby Thain
On 1-May-10, at 4:18 PM, Brian Raderman wrote: Hi David, ... * Removed the dummy1() function from keychain.c. Keychain.c/.h are based on cryptoapi.c/.h in the openvpn source tree. When editing the original file to work with the Keychain services libraries instead of the Windows Crypto A

Re: [Openvpn-devel] [PATCH] Mac OSX Keychain certificate support

2010-05-01 Thread Brian Raderman
Hi David, Thank you for taking a look at the patch and providing such thorough feedback so quickly. I have done everything that you asked: * Changed printf() calls to use msg(). The prints are not actually used right now, but they are a part of the debug code that I wrote for testing the cer