Re: [Openvpn-devel] [PATCH 2/6] Completely remove ancient IANA port warning.

2012-06-22 Thread David Sommerseth
On 18/06/12 20:39, Arne Schwabe wrote: > > Signed-off-by: Arne Schwabe > --- > src/openvpn/init.c|6 -- > src/openvpn/options.c |3 --- > src/openvpn/options.h |1 - > 3 files changed, 0 insertions(+), 10 deletions(-) Applied to master. commit 53c48f41b19331594205f2dd2215d4

Re: [Openvpn-devel] [PATCH 1/6] Only use tmpdir if tmp_dir is really used.

2012-06-22 Thread David Sommerseth
On 18/06/12 20:39, Arne Schwabe wrote: > This fixes starting openvpn compiled as client only version of systems that > have no /tmp (Android). --tmp-dir could only be set if P2MP_SERVER has been > enabled too. > > Signed-off-by: Arne Schwabe > --- > src/openvpn/options.c |7 +-- > src/

Re: [Openvpn-devel] [PATCH] cleanup: pkcs11.c: resolve wanings

2012-06-22 Thread David Sommerseth
On 18/06/12 19:35, Alon Bar-Lev wrote: > src/openvpn/pkcs11.c:794:2: warning: passing argument 1 of > ‘pkcs11h_setPINPromptHook’ from incompatible pointer type > > Signed-off-by: Alon Bar-Lev > --- > src/openvpn/pkcs11.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > ACK. Ap

Re: [Openvpn-devel] [PATCH 3/6] Remove ENABLE_INLINE_FILES conditionals, this code is always enabled and removing the #ifdef make the code a little bit clearer

2012-06-22 Thread David Sommerseth
On 18/06/12 20:39, Arne Schwabe wrote: > > Signed-off-by: Arne Schwabe > --- > src/openvpn/common.h |2 -- > src/openvpn/crypto.c |6 -- > src/openvpn/init.c |4 > src/openvpn/misc.c |6 -- > src/openvpn/options.c | 24 -

Re: [Openvpn-devel] [PATCH 4/6] Remove ENABLE_CONNECTIONS ifdefs, connections were always on for a long time. Not that ENABLE_MAMAGEMENT_REMOTE was only depending on ENABLE_CONNECTIONS and is removed

2012-06-22 Thread David Sommerseth
On 18/06/12 20:39, Arne Schwabe wrote: > > Signed-off-by: Arne Schwabe > --- > src/openvpn/init.c| 12 > src/openvpn/manage.c |8 > src/openvpn/manage.h |6 -- > src/openvpn/options.c | 24 > src/openvpn/options.h | 19 --

Re: [Openvpn-devel] [PATCH] OCC ping

2012-06-22 Thread Samuli Seppänen
Hi Sam, We discussed this patch in our IRC meeting yesterday and we decided to ask for some clarifications... First, is the primary purpose of the patch to save power on the mobile clients? If so, wouldn't it be simpler to just have the client disconnect when it notices that the connection is not

Re: [Openvpn-devel] [PATCH] management: Don't require DAF_INITIAL_AUTH to send ADDRESS/DISCONNECT messages

2012-06-22 Thread Samuli Seppänen
> From: Adrien Bustany > > DAF_INITIAL_AUTH will only be set if a password was needed for client > authentication. This means that for password-less certificate > authentication, no DISCONNECT/ADDRESS messages would be sent. > --- > src/openvpn/manage.c |4 ++-- > 1 files changed, 2 insertio

[Openvpn-devel] Summary of the IRC meeting (21st Jun 2012)

2012-06-22 Thread Samuli Seppänen
Hi, Here's the summary of the previous IRC meeting / sprint. --- COMMUNITY MEETING Place: #openvpn-devel on irc.freenode.net List-Post: openvpn-devel@lists.sourceforge.net Date: Thursday 21st Jun 2012 Time: 18:00 UTC Planned meeting topics for this meeting were on this page:

Re: [Openvpn-devel] [PATCH 3/6] Remove ENABLE_INLINE_FILES conditionals, this code is always enabled and removing the #ifdef make the code a little bit clearer

2012-06-22 Thread David Sommerseth
On 22/06/12 12:16, David Sommerseth wrote: > On 18/06/12 20:39, Arne Schwabe wrote: >> >> Signed-off-by: Arne Schwabe >> --- >> src/openvpn/common.h |2 -- >> src/openvpn/crypto.c |6 -- >> src/openvpn/init.c |4 >> src/openvpn/misc.c |6 --

Re: [Openvpn-devel] [PATCH 4/6] Remove ENABLE_CONNECTIONS ifdefs, connections were always on for a long time. Not that ENABLE_MAMAGEMENT_REMOTE was only depending on ENABLE_CONNECTIONS and is removed

2012-06-22 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22/06/12 12:16, David Sommerseth wrote: > On 18/06/12 20:39, Arne Schwabe wrote: >> >> Signed-off-by: Arne Schwabe --- >> src/openvpn/init.c| 12 src/openvpn/manage.c | >> 8 src/openvpn/manage.h |6 -- >> src/

Re: [Openvpn-devel] [PATCH] OCC ping

2012-06-22 Thread Ed W
On 22/06/2012 11:23, Samuli Seppänen wrote: First, is the primary purpose of the patch to save power on the mobile clients? If so, wouldn't it be simpler to just have the client disconnect when it notices that the connection is not being used and reconnect dynamically when there's usage? That a