Re: [Openvpn-devel] [PATCHv2] ignore UTF-8 byte order mark

2013-02-03 Thread David Sommerseth
On 03/02/13 13:50, Heiko Hund wrote: > Currently openvpn exits when reading configuration from a file > that has an UTF-8 byte order mark (EF BB BF) at its start. > > While it is useless to put a BOM into UTF-8 encoded files, the > Unicode standard [1] permits it (on page 36): > > "Use of a

Re: [Openvpn-devel] option --crl-verify PATH dir

2013-02-03 Thread David Sommerseth
On 03/02/13 12:02, Jan Just Keijser wrote: > hi, > > what is the second option to '--crl-verify' supposed to do? in options.c > it sets a flag SSLF_CRL_VERIFY_DIR which then triggers the function > 'verify_check_crl_dir'. However, this function does not seem to do > anything Quickly

Re: [Openvpn-devel] [PATCHv2] ignore UTF-8 byte order mark

2013-02-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/13 13:50, Heiko Hund wrote: > Currently openvpn exits when reading configuration from a file that > has an UTF-8 byte order mark (EF BB BF) at its start. > > While it is useless to put a BOM into UTF-8 encoded files, the > Unicode standard

Re: [Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2013-02-03 Thread Arne Schwabe
Am 03.02.13 14:55, schrieb Jan Just Keijser: > Arne Schwabe wrote: >> Am 16.08.12 10:38, schrieb Heiko Hund: >> >>> cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB >>> are used the assertion outlen == iv_len is always false. >>> >>> There's no CBC mode defined for the GOST

Re: [Openvpn-devel] [PATCH applied] Re: Removed ChangeLog.IPv6

2013-02-03 Thread Gert Doering
Hi, On Sun, Feb 03, 2013 at 02:55:38PM +0100, Gert Doering wrote: > Your patch has been applied to the master and release/2.3 branch. > > commit a93ed2e64cd57a63ca5e9a393cee9bc58ef32378 (master) > commit 5a1c16e7d0fe28666000928479e5b4c0702a9e30 (release/2.3) > > Author: Samuli Seppänen As a

[Openvpn-devel] [PATCH applied] Re: Cleaned up and updated INSTALL

2013-02-03 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit 607a678d371c56d368319b0a7a1bb147008d5822 (master) commit 901f647ddbd771086814b9ca050e166182fb3371 (release/2.3) Author: Samuli Seppänen List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Jan 25 11:59:34 2013 +0200

[Openvpn-devel] [PATCH applied] Re: Updated README

2013-02-03 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit 7e0d16a9d6b9a972e5449d9d588545fdbd4ec46c (master) commit cd088e4b4cd7ff5c6be9e9c5ff2854695028685a (master) Author: Samuli Seppänen List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Jan 25 10:12:19 2013 +0200

[Openvpn-devel] [PATCH applied] Re: Added cross-compilation information INSTALL-win32.txt

2013-02-03 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit 168780d0df95a37b652e133483c722aefa40cb80 (master) commit 10675f36212e32d8fa1993712cdb35fba12da21f (release/2.3) Author: Samuli Seppänen List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Jan 25 10:12:18 2013 +0200

Re: [Openvpn-devel] [PATCH 1/7] refine assertion to allow other modes than CBC

2013-02-03 Thread Jan Just Keijser
Arne Schwabe wrote: Am 16.08.12 10:38, schrieb Heiko Hund: cipher_ctx_final() only returns an outlen in CBC mode. If CFB or OFB are used the assertion outlen == iv_len is always false. There's no CBC mode defined for the GOST 28147-89 block cipher. Hence this patch is needed for it to work.

[Openvpn-devel] [PATCH applied] Re: Removed ChangeLog.IPv6

2013-02-03 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit a93ed2e64cd57a63ca5e9a393cee9bc58ef32378 (master) commit 5a1c16e7d0fe28666000928479e5b4c0702a9e30 (release/2.3) Author: Samuli Seppänen List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Jan 25 10:12:17 2013 +0200

[Openvpn-devel] [PATCH applied] Re: Enable TCP_NODELAY configuration on FreeBSD.

2013-02-03 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit 3e86f688757529f8b33f9e6b49e31ba8d8564c5e (master) commit 0a700901a3bbc97e51a6319580129a131f202889 (release/2.3) Author: Matthias Andree List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Jan 12 13:41:17 2013 +0100

[Openvpn-devel] [PATCH applied] Re: man page patch for missing options

2013-02-03 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branch. commit d94873f6cc2c24e29964e4483b0bc02653860deb (master) commit 967c5d8ea5bf6d5ad72adab5c1b76249f7f2b9d3 (release/2.3) Author: Jan Just Keijser List-Post: openvpn-devel@lists.sourceforge.net Date: Sun, 03 Feb 2013 12:00:20 +0100

[Openvpn-devel] [PATCHv2] ignore UTF-8 byte order mark

2013-02-03 Thread Heiko Hund
Currently openvpn exits when reading configuration from a file that has an UTF-8 byte order mark (EF BB BF) at its start. While it is useless to put a BOM into UTF-8 encoded files, the Unicode standard [1] permits it (on page 36): "Use of a BOM is neither required nor recommended for UTF-8,

[Openvpn-devel] Gert Döring now the co-maintainer with David Sommerseth

2013-02-03 Thread Samuli Seppänen
Hi all, In order to speed up patch management and other daily development tasks Gert Döring ("cron2") is sharing some of the development responsibilities with David Sommerseth ("dazo"). In practice, both Gert or David can now push patches to GitHub and SF.net Git repos. -- Samuli Seppänen

Re: [Openvpn-devel] man page patch for missing options

2013-02-03 Thread Gert Doering
Hi, On Sun, Feb 03, 2013 at 12:00:20PM +0100, Jan Just Keijser wrote: > attached is a man page patch to include the options that were made > connection-entry specific (by a patch of mine, which is included in 2.3.0). ACK. Thanks for the update, 2.3.0 was indeed lacking a bit in the

Re: [Openvpn-devel] [PATCH] Remove dead code path and putenv functionality

2013-02-03 Thread Gert Doering
HI, On Sun, Feb 03, 2013 at 12:12:31PM +0100, Arne Schwabe wrote: > The construct_name_value function call will always fail so this code path is > never used. Since we now always have a valid environment in > static_context->c2.es it is better to have a ASSERT(es) than to call this > code

[Openvpn-devel] [PATCH] Remove dead code path and putenv functionality

2013-02-03 Thread Arne Schwabe
The construct_name_value function call will always fail so this code path is never used. Since we now always have a valid environment in static_context->c2.es it is better to have a ASSERT(es) than to call this code patch. Signed-off-by: Arne Schwabe --- src/openvpn/misc.c

[Openvpn-devel] man page patch for missing options

2013-02-03 Thread Jan Just Keijser
hi all, attached is a man page patch to include the options that were made connection-entry specific (by a patch of mine, which is included in 2.3.0). see you in a bit, JJK diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 2ed5201..829bbd2 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@

[Openvpn-devel] [PATCH applied] Re: Update README.IPv6 to match what is in 2.3.0

2013-02-03 Thread Gert Doering
This patch has been applied to the master and release/2.3 branch. commit c2f4c1918202f4395438663804b0806c93790501 (master) commit 5085ae1cbb8cee5e4a28d7c0a091cba340cbe0ef (release/2.3) Author: Gert Doering List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Jan 25 12:39:14 2013 +0100

Re: [Openvpn-devel] [PATCH] ignore UTF-8 byte order mark

2013-02-03 Thread Heiko Hund
On Saturday 02 February 2013 17:47:40 David Sommerseth wrote: > Wouldn't this approach solve it in an easier way? > >int offset = 0; >if (line_num == 1 && strncmp (line, "\xEF\xBB\xBF", 3) == 0) > offset = 3 > >if (parse_line (line+offset, p, SIZE (p), file,