Re: [Openvpn-devel] [PATCH] Implement an easy parsable log output that allows access to flags of the log message

2014-03-21 Thread Gert Doering
Hi, On Tue, Dec 17, 2013 at 02:02:06PM +0100, Gert Doering wrote: > On Tue, Dec 17, 2013 at 12:21:39PM +0100, Arne Schwabe wrote: > > @@ -2273,6 +2273,12 @@ otherwise would be prepended. In particular, this > > applies to > > log messages sent to stdout. > > .\"*

[Openvpn-devel] [PATCH applied] Re: Fix connecting to localhost on Android

2014-03-21 Thread Gert Doering
ACK. Patch has been applied to the master branch. (It's only affecting #ifdef ANDROID, and if you tell me it needs it, that's good enough for me) commit 5118787158eb6fafa3bfef9cb87acb1c76264a90 Author: Arne Schwabe List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Mar 21 14:18:34 2014 +

[Openvpn-devel] [PATCH 10/12] Clean up of socket code.

2014-03-21 Thread Arne Schwabe
Let socket_create take struct addrinfo as argument and use the entries of addrinfo to create the socket. --- src/openvpn/manage.c | 6 +- src/openvpn/socket.c | 187 +-- src/openvpn/socket.h | 6 +- 3 files changed, 95 insertions(+), 104 deletio

[Openvpn-devel] [PATCH 07/12] Don’t show the connection profile store in options->ce if there is a connection_list defined.

2014-03-21 Thread Arne Schwabe
Entries in options->ce are never used and overwritten by the first usable connection profile on initialisation. --- src/openvpn/options.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index cb2cf95..c5746c5 100644 --- a/sr

[Openvpn-devel] [PATCH 05/12] Introduce an option to resolve dns names in advance for —remote, —local and http-proxy

2014-03-21 Thread Arne Schwabe
Also introduce x_gc_addspeical function that allows to add objects with a custom free function to the gc. Some additional addrinfo cleanup Conflicts: src/openvpn/socket.c --- src/openvpn/buffer.c | 38 + src/openvpn/buffer.h | 28 +++- src/openvpn/init.c| 33 +++-- src/open

[Openvpn-devel] [PATCH 09/12] Don’t redirect the gateway on Android even if requested

2014-03-21 Thread Arne Schwabe
Routing loops are avoided using the VPNService API --- src/openvpn/route.c | 4 1 file changed, 4 insertions(+) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 13eed5f..eb5fb46 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -530,8 +530,10 @@ add_block_local (struc

[Openvpn-devel] [PATCH 04/12] Implement an easy parsable log output that allows access to flags of the log message

2014-03-21 Thread Arne Schwabe
--- doc/openvpn.8 | 6 ++ src/openvpn/error.c | 28 +++- src/openvpn/error.h | 2 ++ src/openvpn/options.c | 8 src/openvpn/options.h | 1 + 5 files changed, 44 insertions(+), 1 deletion(-) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index d01c9

[Openvpn-devel] [PATCH 02/12] Move the initialization of the environment to the top so c2.es is initialized

2014-03-21 Thread Arne Schwabe
--- src/openvpn/init.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 3b72b96..c50b5c2 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -3339,6 +3339,10 @@ init_instance (struct context *c, const struct env_set

[Openvpn-devel] [PATCH 01/12] Fix connecting to localhost on Android

2014-03-21 Thread Arne Schwabe
Do not protect the link socket when connecting to localhost. Also only call the protect function on valid socket --- src/openvpn/socket.c | 21 ++--- src/openvpn/socket.h | 17 + 2 files changed, 35 insertions(+), 3 deletions(-) diff --git a/src/openvpn/socket.c b

[Openvpn-devel] [PATCH 06/12] Fix for server selecting address family

2014-03-21 Thread Arne Schwabe
--- src/openvpn/socket.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index bf793f4..97f6756 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -1509,21 +1509,10 @@ create_new_socket (struct

[Openvpn-devel] [PATCH 12/12] Fix client-nat only working is also mss-fix is specified.

2014-03-21 Thread Arne Schwabe
Also make sure that with this fix compiling without ENABLE_CLIENT_NAT does not result in always checking the ip header --- src/openvpn/forward.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c index 0ec00f3..453ab3f

[Openvpn-devel] [PATCH 00/12] Patches from OpenVPN for Android

2014-03-21 Thread Arne Schwabe
To minimise the difference between my local ics-openvpn OpenVPN branch and the official master I am sending the patches which I think should be applied to master but are not yet applied yet. Arne Schwabe (12): Fix connecting to localhost on Android Move the initialization of the environment

[Openvpn-devel] [PATCH 03/12] Workaround broken Android 4.4 VpnService API for persist-tun mode

2014-03-21 Thread Arne Schwabe
In Android 4.4 it is not possible to open a new tun device and then close the old tun device without breaking the whole VPNService stack until the device is reported. This management method ask the UI what method should be taken to ensure the optimal solution for the situation. --- src/openvpn/ini

[Openvpn-devel] [PATCH 11/12] Fix assert when using port-share

2014-03-21 Thread Arne Schwabe
--- src/openvpn/ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/ps.c b/src/openvpn/ps.c index 901a094..6807aac 100644 --- a/src/openvpn/ps.c +++ b/src/openvpn/ps.c @@ -803,7 +803,7 @@ port_share_open (const char *host, * Get host's IP address */ - sta

[Openvpn-devel] [PATCH 08/12] Add gateway and device to android control messages

2014-03-21 Thread Arne Schwabe
--- src/openvpn/route.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 1dd14fb..13eed5f 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1311,9 +1311,12 @@ add_route (struct route_ipv4 *r, status = openv