Re: [Openvpn-devel] [PATCH] Privileges not being dropped if the first connection is not successful

2015-09-03 Thread Gert Doering
Hi, On Thu, Sep 03, 2015 at 10:18:36PM +0200, Lukasz K. wrote: > With above in mind I decided to introduce this change to the patch. > > I also included few other "improvements" to make the function appear > more consistent and more obvious (like "c0->uid_gid_chroot_set = true" > separated and pu

Re: [Openvpn-devel] [PATCH] Privileges not being dropped if the first connection is not successful

2015-09-03 Thread Lukasz K.
> While the patch is designed to only fix the problem I was thinking if > it wouldn't be perhaps better to rename "context_0.uid_gid_set" to > something more function related like "context_0.uid_gid_chroot_set", > to make it more obvious for people who would look at the code in the > future that th

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-09-03 Thread Rafael Gava
Hello All, I'm looking forward to hearing from you guys a feedback if the patch for the features added to the NAT will be accepted or not or if is there anything else that I need to do or change in order to have it merged into the code. >From the previous replies, it seems that a minor change was

Re: [Openvpn-devel] [PATCH] Privileges not being dropped if the first connection is not successful

2015-09-03 Thread Lukasz K.
"context_0.uid_gid_set" has already been since 2.1.3 (and probably earlier versions) serving as a dedicated way of guarding "do_uid_gid_chroot()" from executing privilege dropping area twice (if you take "context.first_time" out of the way first and put "first_time" checks to calls [the ones outsid

Re: [Openvpn-devel] [PATCH] Add missing strdup() return value checks

2015-09-03 Thread Arne Schwabe
Am 26.08.15 um 00:29 schrieb Steffan Karger: > As reported by Bill Parker in trac #600, strdup() return values are not > always correctly checked for failed allocations. This patch adds missing > checks. > > Note that in misc.c and options.c, the check is after the dirname() or > basename() call,