Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Selva Nair
On Mon, Jul 4, 2016 at 5:01 PM, Arne Schwabe wrote: > > Or do you have tcp-client in mind? In case of tcp-client, before this > > patch, "--connect-retry 0" will hammer the server with repeated > > retries. That will be avoided as max sec defaults to 300 sec, unless > > the user specifies "--con

Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Arne Schwabe
> Or do you have tcp-client in mind? In case of tcp-client, before this > patch, "--connect-retry 0" will hammer the server with repeated > retries. That will be avoided as max sec defaults to 300 sec, unless > the user specifies "--connect-retry 0 0". Shall we require that the > second arg to c

Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Selva Nair
On Mon, Jul 4, 2016 at 12:02 PM, Arne Schwabe wrote: > > > > Something like this is needed to protect against overflow of the 32 > > bit int (signed int in this case). Think of the user specifying sec = > > 2^17. Any shift by more than 14 will make sec = 0. A more > > sophisticated logic that co

Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Arne Schwabe
Am 04.07.16 um 17:43 schrieb Selva Nair: > > Something like this is needed to protect against overflow of the 32 > bit int (signed int in this case). Think of the user specifying sec = > 2^17. Any shift by more than 14 will make sec = 0. A more > sophisticated logic that counts the bits in sec b

Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Selva Nair
Hi, On Mon, Jul 4, 2016 at 5:23 AM, Arne Schwabe wrote: > - sndbuf and recvbuf default now to OS default instead of 64k > > > > @@ -120,6 +120,10 @@ User-visible Changes > > - --http-proxy-retry and --sock-proxy-retry have been removed. Proxy > connections > > will now behave like regular

Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Arne Schwabe
Am 03.07.16 um 01:34 schrieb Selva Nair: > - When the number of retries per remote exceeds a limit > (hard coded to 5), double the restart pause interval > for each additional retry per remote. > - Trigger a SIGHUP to reset the retry count when the pause > interval exceeds 1024 times the ba

Re: [Openvpn-devel] git master: no more WinXP ?

2016-07-04 Thread Samuli Seppänen
Hi, On Wed, Jun 29, 2016 at 01:17:10PM +0300, Samuli Seppänen wrote: We can definitely add a checkbox for the interactive service. However, I would make it opt-out to reduce the impact on support. Only a handful of people know that in order to run OpenVPN-GUI without admin privileges requires

[Openvpn-devel] [PATCH] Deprecate the automatic part of openvpnserv.exe in favor of openvpnserv2.exe

2016-07-04 Thread samuli
From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- src/openvpnserv/automatic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpnserv/automatic.c b/src/openvpnserv/automatic.c index 9b424e9..aa7618f 100644 --- a/src/openvpnserv/automatic.c +++ b/src/openvp

Re: [Openvpn-devel] [PATCH v2] Exponentially back off on repeated connect retries

2016-07-04 Thread Arne Schwabe
Am 03.07.16 um 01:34 schrieb Selva Nair: > - When the number of retries per remote exceeds a limit > (hard coded to 5), double the restart pause interval > for each additional retry per remote. > - Trigger a SIGHUP to reset the retry count when the pause > interval exceeds 1024 times the ba

Re: [Openvpn-devel] Windows service changes

2016-07-04 Thread Samuli Seppänen
Hi, On Thu, Jun 30, 2016 at 11:04 AM, Samuli Seppänen mailto:sam...@openvpn.net>> wrote: The installer linked to above implement all of the above. However, these three changes are required for things to work properly: