ACK!
Your patch has been applied to the master branch.
commit dea8917a032e2303b39cce23e60f2348516d5a12
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Tue Jul 26 15:55:38 2016 +0200
Fix '--cipher none --cipher' crash
Signed-off-by: Steffan Karger
Ac
ACK!
Your patch has been applied to the release/2.3 branch.
commit d1c08ab1365096fdbd02cfb4f9ad97e759f13b82
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date: Tue Jul 26 15:57:13 2016 +0200
Fix '--cipher none --cipher' crash
Signed-off-by: Steffan Karger
As reported in trac #699, OpenVPN crashes when an "--cipher none" option
is followed by "--cipher" (without arguments). Fix the crash, and print a
warning to indicate that using --cipher of --auth without an argument is
deprecated.
This is a (partly) backport of the patch I sent for the master br
As reported in trac #699, OpenVPN crashes when an "--cipher none" option
is followed by "--cipher" (without arguments). Fix this by removing the
redudant ciphername_defined and authname_defined members of struct options,
and remove support to specify --cipher or --auth without an argument. That
n
Hi JJK,
On 26-07-16 04:17, Jan Just Keijser wrote:
> ACK from me, but just to nitpick:
>
> we now have an option 'disable-occ' and an option 'ncp-disable' -
> wouldn't it make more sense to make it "disable-ncp" as well?
Yes, I considered this, but I like --ncp-disable more because:
* it has s
Hi,
On Tue, Jul 26, 2016 at 04:09:16AM +0200, Jan Just Keijser wrote:
> > Anyone having a good argument against it? JJK, do you happen to know
> > what this is about?
>
> this is from even before my time ;)
Fun :-)
> I didn't even know that you could specify cipher without an argument -
> le
ACK from me, but just to nitpick:
we now have an option 'disable-occ' and an option 'ncp-disable' -
wouldn't it make more sense to make it "disable-ncp" as well?
JJK
On 25/07/16 20:52, Steffan Karger wrote:
This allows the ncp-disable and ncp-ciphers options to be used in 'client
config dir'
Hi Gert,
On 25/07/16 22:04, Gert Doering wrote:
Hi,
has anyone ever used "--cipher" without an argument? If yes, what is the
intended usage? It sort of "tells openvpn we want crypto!" but does not
go into detail about it...
Normally, this would just be a random weird option, but I ran across
