[Openvpn-devel] [PATCH applied] Re: console: Fix compiler warning

2016-11-12 Thread Gert Doering
ACK. Compile-tested only (this is the sort of change that either breaks at compilation or not :) ) Your patch has been applied to the master branch. commit 14cb1639f7694cdd461bace5e273acd7722cd3cf Author: David Sommerseth Date: Fri Nov 11 14:30:07 2016 +0100 console: Fix compiler

Re: [Openvpn-devel] [PATCH] tun: Fix compiler warnings

2016-11-12 Thread Gert Doering
Hi, On Fri, Nov 11, 2016 at 02:16:41PM +0100, David Sommerseth wrote: > @@ -917,6 +915,12 @@ do_ifconfig (struct tuntap *tt, >management_android_control (management, "IFCONFIG", buf_bptr()); > > #elif defined(TARGET_SOLARIS) > + const char *ifconfig_ipv6_remote = NULL; > + > +

Re: [Openvpn-devel] [PATCH] systemd: Improve the systemd unit files

2016-11-12 Thread Gert Doering
Hi, On Fri, Nov 11, 2016 at 01:35:57PM +0100, David Sommerseth wrote: > We can of course investigate if we should enable systemd to restart > OpenVPN, at least the server profile, if it dies unexpectedly. > Currently, I am not fully convinced we want that. I think this would be useful to have.

Re: [Openvpn-devel] [PATCH v2] systemd: Improve the systemd unit files

2016-11-12 Thread debbie10t
On 12/11/16 11:38, David Sommerseth wrote: > There are several changes which allows systemd to take care of several > aspects of hardening the execution of OpenVPN. > > - Let systemd take care of the process tracking directly, instead > of doing that via PID files > > - Make systemd prepare

Re: [Openvpn-devel] [PATCH 3/5] Add missing includes in error.h

2016-11-12 Thread David Sommerseth
On 08/11/16 21:18, Steffan Karger wrote: > error.h depends on these, but is apparently never used by files that do > not include them. When implementing the --tls-crypt unit tests, I ran > into this. > > Signed-off-by: Steffan Karger > --- > src/openvpn/error.h | 3

Re: [Openvpn-devel] [PATCH 4/5] Move private file access checks to options_postprocess_filechecks()

2016-11-12 Thread David Sommerseth
On 08/11/16 21:18, Steffan Karger wrote: > From: Steffan Karger > > This removes the dependency of crypto.c on misc.c, which makes testing > (stuff that needs) crypto.c functionality easier. In particular, this > simplifies the --tls-crypt tests in one of the follow-up

[Openvpn-devel] [PATCH v2] systemd: Improve the systemd unit files

2016-11-12 Thread David Sommerseth
There are several changes which allows systemd to take care of several aspects of hardening the execution of OpenVPN. - Let systemd take care of the process tracking directly, instead of doing that via PID files - Make systemd prepare proper runtime directories for the OpenVPN process. -