Re: [Openvpn-devel] [PATCH] tests: Add a simple build sanity check

On 12/08/17 12:33, Steffan Karger wrote: [...] >> --- >> tests/Makefile.am | 2 +- >> tests/t_sanity_check.sh | 118 >> > > t_sanity_check is less descriptive than the t_usage proposed by Ilya. > (Sanity check could be anything, while we

Re: [Openvpn-devel] In P2P and IPv6 only mode: do_ifconfig() does not set up tun interface

Hi, On Sat, Aug 12, 2017 at 05:07:00PM +0200, Michael Kress wrote: > it seems that OpenVPN in P2P mode (static keys) doesn't configure and > start the tun interface when there are no configured IPv4 addresses: > > OpenVPN 2.4.3 > In "void do_ifconfig()" of tun.c line 881: if

[Openvpn-devel] In P2P and IPv6 only mode: do_ifconfig() does not set up tun interface

Hello list, it seems that OpenVPN in P2P mode (static keys) doesn't configure and start the tun interface when there are no configured IPv4 addresses: OpenVPN 2.4.3 In "void do_ifconfig()" of tun.c line 881: if (tt->did_ifconfig_setup) The flag tt->did_ifconfig_ipv6_setup is not considered at

Re: [Openvpn-devel] [PATCH] tests: Add a simple build sanity check

Hi, Some high-level comments: On 09-08-17 14:32, David Sommerseth wrote: > This runs openvpn --help to check if the output is somewhat > sensible and sane. It will catch if the binary segfaults, > if it is a normal build or an --enable-small build and > does some simple checks when a list of

Re: [Openvpn-devel] [PATCH v2] tls-crypt: introduce tls_crypt_kt()

Hi, On 12/08/17 17:53, Steffan Karger wrote: > Reduces code duplication (and prepares for tls-crypt-v2, which needs the > same functionality at more places). > > Because tls_crypt_kt() is a static function we now need to include > tls_crypt.c from the tests, rather than tls_crypt.h. > >

Re: [Openvpn-devel] [PATCH] tls-crypt: introduce tls_crypt_kt()

Hi, On 12-08-17 06:36, Antonio Quartulli wrote: > On 25/07/17 22:33, Steffan Karger wrote: >> @@ -60,23 +60,9 @@ setup(void **state) { >> struct test_context *ctx = calloc(1, sizeof(*ctx)); >> *state = ctx; >> >> -ctx->kt.cipher = cipher_kt_get("AES-256-CTR"); >> -

[Openvpn-devel] [PATCH v2] tls-crypt: introduce tls_crypt_kt()

Reduces code duplication (and prepares for tls-crypt-v2, which needs the same functionality at more places). Because tls_crypt_kt() is a static function we now need to include tls_crypt.c from the tests, rather than tls_crypt.h. Signed-off-by: Steffan Karger --- v2: