Re: [Openvpn-devel] [PATCH] Allow to specify bind interface for outbound/inbound connections

2017-09-21 Thread Maximilian Wilhelm
Anno domini 2017 Maximilian Wilhelm scripsit: Hi, for the record: I've updated the PR on github and addressed the issues raised here before. -> https://github.com/OpenVPN/openvpn/pull/65#issuecomment-330715591 The point remaining is the support for FreeBSD: [...] > > > + if (sock->bind_dev)

Re: [Openvpn-devel] [PATCH applied] Fix bounds check in read_key()

2017-09-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Even though this fix have been backported and applied to release/2.3 and older, we will only plan releases for v2.3 and v2.4. We have mainly backported this issue to release/2.3, but it was very easy to cherry-pick this fix to the older branches; th

Re: [Openvpn-devel] [PATCH applied] systemd: Enable systemd's auto-restart feature for server profiles

2017-09-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Applying lazy-ack policy to this patch. Despite one reservation to this change, the overall discussion was in favour of this enhancement. Your patch has been applied to the following branches commit a4686e99b047081f0ef6f7945450183088464aa5 (maste

Re: [Openvpn-devel] [PATCH applied] tcp-server: ensure AF family is propagated to child context

2017-09-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit 682e7feac3bd57e6ce7e60504cb4da5c894d0e18 (master) commit b3b7d073ce05fa6b11a28f9e70d66c4907274db5 (release/2.4) Author: Antonio Quartulli Date: Thu Sep 7 17:55:30 2017 +0800 tcp-

Re: [Openvpn-devel] [PATCH applied] systemd: Ensure systemd shuts down OpenVPN in a proper way

2017-09-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Applying lazy-ack policy to this patch. Your patch has been applied to the following branches commit 29446a18e1f2b52d20f359253b085e96fe458367 (master) commit b49c1ca407e046debebf5633c117d679b9e20555 (release/2.4) Author: David Sommerseth Date:

[Openvpn-devel] Remote memory corruption

2017-09-21 Thread Guido Vranken
Hello, this concerns key_method 1. I know it's deprecated, but reporting it just in case people still use it.. So key_method_1_read() calls read_key() which doesn't perform adequate bounds checks. cipher_length and hmac_length are specified by the peer: 1643 uint8_t cipher_length; 1644 u

Re: [Openvpn-devel] Remote memory corruption

2017-09-21 Thread Gert Doering
Hi, On Tue, Aug 15, 2017 at 10:10:32AM +0200, Steffan Karger wrote: [..] > To all: following <54fc26bb.2000...@karger.me> and commit 1ce06386, I > think it really is time to remove key method 1 from the master branch. > > Attached a proposed patch to fix this issue in release/2.4 and master. > >

Re: [Openvpn-devel] Remote memory corruption

2017-09-21 Thread Steffan Karger
Hi, On 14-08-17 22:59, Guido Vranken wrote: > this concerns key_method 1. I know it's deprecated, but reporting it > just in case people still use it.. > > So key_method_1_read() calls read_key() which doesn't perform adequate > bounds checks. cipher_length and hmac_length are specified by the >

Re: [Openvpn-devel] Remote memory corruption

2017-09-21 Thread Steffan Karger
On 15-08-17 10:10, Steffan Karger wrote: > On 14-08-17 22:59, Guido Vranken wrote: >> this concerns key_method 1. I know it's deprecated, but reporting it >> just in case people still use it.. >> >> So key_method_1_read() calls read_key() which doesn't perform adequate >> bounds checks. cipher_leng

[Openvpn-devel] (no subject)

2017-09-21 Thread อุดร จันสน
ขอยกเลิกบริการและการรับข้อมูล -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Openvpn-devel maili

Re: [Openvpn-devel] [PATCH v2] lz4: Move towards a newer LZ4 API

2017-09-21 Thread David Sommerseth
On 07/09/17 22:40, Simon Matter wrote: > Hi, > > While we are at it, I found it useful to see the used LZ4 version at > runtime as it is done with LZO and other libraries. > > I've patched my rpms with the patch attached. Thanks a lot! I think this makes sense. But I think we can do this stuff

Re: [Openvpn-devel] Better error recognition and error/status reporting to the mgmt i/f

2017-09-21 Thread David Sommerseth
On 14/09/17 21:21, Selva wrote: > Hi, Hi Selva, Sorry for the long wait. Things have been quite busy since that meeting. > > Quoting from the meeting logs: >   > > Discussed having more fine-grained signalling from OpenVPN to OpenVPN > GUI. The lack of clear signals from OpenVPN to Op

Re: [Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

2017-09-21 Thread David Sommerseth
On 15/09/17 08:39, Steffan Karger wrote: > close_instance() tries to remove the file in c2.pf.filename, but that only > works if we actually set that if we fail. So, set that filename as soon > as we know we've created the file. > > Signed-off-by: Steffan Karger > --- > v2: As suggested by Antio

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-21 Thread David Sommerseth
On 14/09/17 23:34, Steffan Karger wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but just reject the connecting client. > > This commit changes the function to

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-21 Thread sameer.s.athaley
Please stop sending me mails u fools, this is not unsubscribing fed up of this. Remove my mail I'd for GOD sacks On 15-Sep-2017 3:05 AM, "Steffan Karger" wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In su

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

2017-09-21 Thread Antonio Quartulli
Hi, On 15/09/17 05:34, Steffan Karger wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but just reject the connecting client. > > This commit changes the functio

Re: [Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

2017-09-21 Thread Antonio Quartulli
On 15/09/17 14:39, Steffan Karger wrote: > close_instance() tries to remove the file in c2.pf.filename, but that only > works if we actually set that if we fail. So, set that filename as soon > as we know we've created the file. > > Signed-off-by: Steffan Karger > --- > v2: As suggested by Ant

Re: [Openvpn-devel] [PATCH v2] Check whether in pull_mode before warning about previous connection blocks

2017-09-21 Thread Antonio Quartulli
On 20/09/17 23:34, Selva wrote: > Hi, > > On Fri, Sep 15, 2017 at 2:46 PM, wrote: > >> From: Selva Nair >> >> In particular, this eliminates the message that says "explicit-exit-notify >> is ignored by previous blocks" when the option is pushed. >> >> Note: pull_mode is identified as "allowe