[Openvpn-devel] [PATCH applied] Re: lz4: Fix broken builds when pkg-config is not present but system library is

2017-10-02 Thread Gert Doering
ACK. Tested locally. Now let's see what MacOS thinks about it :-) Your patch has been applied to the master and release/2.4 branch. commit e5b279f1b62e75569ee8d988b55e6ee0dc93464e (master) commit c70a80b1b73d658bfe16225048d95958daf034e7 (release/2.4) Author: David Sommerseth Date: Mon Oct 2

[Openvpn-devel] [PATCH] lz4: Fix broken builds when pkg-config is not present but system library is

2017-10-02 Thread David Sommerseth
In commit f91e4863bc1382 we fixed an issue where LZ4_LIBS could be overwritten in some situations. But on systems where lz4 is installed on the system but is lacking pkg-config information, the linker will not know about the lz4 library when completing the build. This fixes the issue by

[Openvpn-devel] [PATCH applied] Re: lz4: Fix confused version check

2017-10-02 Thread Gert Doering
ACK. Makes sense, got tested on our problem child (Debian 8) already, and I added more tests of my own (Ubuntu 14.04 with "too old lz4 library", FreeBSD with 1.8.0, Gentoo with "no lz4 library") and everything worked nicely. thanks. Your patch has been applied to the master and release/2.4

[Openvpn-devel] [PATCH] lz4: Fix confused version check

2017-10-02 Thread David Sommerseth
Older LZ4 library versions used a version number > 100 and not the current x.y.z versioning scheme. This results in version 122 being numberically higher than the check we have liblz4 > 1.7.1. And since that old version (122) does not have the LZ4_compress_default(), the building explodes later