[Openvpn-devel] Summary of the community meeting (Wed, 6th Dec 2017)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wednesday 6th Dec 2017 Time: 11:30 CET (10:30 UTC) Planned meeting topics for this meeting were here: The next me

Re: [Openvpn-devel] [PATCH v2] Use lowest metric interface when multiple interfaces match a route

2017-11-06 6:14 GMT+05:00 : > From: Selva Nair > > Currently a route addition using IPAPI or service is skipped if the > route gateway is reachable by multiple interfaces. This changes that > to use the interface with lowest metric. Implemented by > > (i) Do not over-write the return value with

Re: [Openvpn-devel] [PATCH v2] Use lowest metric interface when multiple interfaces match a route

On Wed, Dec 6, 2017 at 8:28 AM, Илья Шипицин wrote: > > > 2017-11-06 6:14 GMT+05:00 : >> >> .. >> +/** >> + * Given an interface index return the interface metric. >> + * >> + * Arguments: >> + * index : The index of the interface >> + * family: AF_INET for IPv4 or AF_INET6 for

[Openvpn-devel] [PATCH v3] Allow learning iroutes with network made up of all 0s (only if netbits < 8)

It is plausible for a user to be willing to add a route for a network made up of all 0s via a VPN client (i.e. 0.0.0.0/1), therefore such iroute should be supported. As of now the option parsing code will accept such iroute, but the learning routine will (silently) reject it after a sanity check.

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, > > The get_interface_metric() function should get a more thorough rewrite > than just a compiler warning shut-up. So the patch will probably get divided > in two - the simple signed/unsigned fixes and get_interface_metric() > redesign. > > For the latter, I had "re-invented" the get_interfac

Re: [Openvpn-devel] [PATCH] Refactor get_interface_metric to return metric and auto flag separately

Hi, I have briefly reviewed this patch. If you look at each get_interface_metric() call you'll notice exactly the same repeating pattern: tap_metric_v4 = get_interface_metric(index, AF_INET, &is_auto); if (is_auto) { tap_metric_v4 = 0; } tap_me

Re: [Openvpn-devel] [PATCH] Refactor get_interface_metric to return metric and auto flag separately

Hi, On Wed, Dec 6, 2017 at 12:18 PM, Simon Rozman wrote: > Hi, > > I have briefly reviewed this patch. If you look at each > get_interface_metric() call you'll notice exactly the same repeating > pattern: > > tap_metric_v4 = get_interface_metric(index, AF_INET, &is_auto); > if (i

Re: [Openvpn-devel] [PATCH applied] reload HTTP proxy credentials when moving to the next connection profile

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK from me as well. Code looks sane and have tested this against a quickly patched tinyproxy [1] with basic auth support. The client switched between three different connection blocks, all depending on which tinyproxy instance I brought up or took

Re: [Openvpn-devel] [PATCH applied] Allow learning iroutes with network made up of all 0s (only if netbits < 8)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 ACK. Code makes sense and seems not to break an existing server configuration I have. Your patch has been applied to the following branches commit a19c56db9bd42b7b8c4a8f353f7db92781397cec (master) commit 80614c7c547c84e0884cf2bde1dbbac76b4767c3

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, On Wed, Dec 6, 2017 at 12:10 PM, Simon Rozman wrote: > Hi, > >> > The get_interface_metric() function should get a more thorough rewrite >> than just a compiler warning shut-up. So the patch will probably get divided >> in two - the simple signed/unsigned fixes and get_interface_metric() >> r

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, > > Should your patch be merged, I shall rebase the "[PATCH 09/13] > Signed/unsigned warnings of MSVC resolved" to the new master and deliver > the next version. > > Yes, if you can review and ack/nak it :) You mean Gert to ack/nak it? I don't believe I have earned enough reputation to do it

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, On Thu, Dec 07, 2017 at 06:41:03AM +, Simon Rozman wrote: > > > Should your patch be merged, I shall rebase the "[PATCH 09/13] > > Signed/unsigned warnings of MSVC resolved" to the new master and deliver > > the next version. > > > > Yes, if you can review and ack/nak it :) > > You mean G