Re: [Openvpn-devel] tap-windows6 and AppVeyor

2018-06-15 Thread Jon Kunkee via Openvpn-devel
Hi, I like the idea of asking AppVeyor if they could include the EWDK in one of their images. It is a standalone tool, so Visual Studio is not needed. Sadly I don't see a Chocolatey package for the EWDK. That would have been convenient. The AppVeyor docs[1] say that the Visual Studio 2017 imag

Re: [Openvpn-devel] [PATCH 09/10] Move execve/run_script helper functions to run_command.c

2018-06-15 Thread Antonio Quartulli
Hi, On 08/12/17 20:07, Steffan Karger wrote: > From: Steffan Karger > > To avoid having to include misc.c - which is a dependency mess - in the > tls-crypt unit tests, move the command execution helper functions to a new > run_command.c module. > > While at it, abstract away the script_security

Re: [Openvpn-devel] [PATCH 08/10] Move file-related functions from misc.c to platform.c

2018-06-15 Thread Antonio Quartulli
On 08/12/17 20:07, Steffan Karger wrote: > To avoid having to include misc.c - which is a dependency mess - in the > tls-crypt unit tests, move file-handing related functions to platform.c > (which is where other file-related functions already reside). > > Signed-off-by: Steffan Karger I have

Re: [Openvpn-devel] tap-windows6 and AppVeyor

2018-06-15 Thread Илья Шипицин
hi, I have some very amazing expirience with app veyor when I was playing with mingw builds. there was an issue related to mingw and I saw it between builds (mingw upgraded), so I first decided "could it be app veyor ?!" people from app veyor were very helpful in troubleshooting that. so, I gue

Re: [Openvpn-devel] [PATCH 01/10] Add crypto_pem_{encode,decode}()

2018-06-15 Thread Antonio Quartulli
Hi Steffan, On 08/12/17 20:07, Steffan Karger wrote: > Needed for tls-crypt-v2, but isolated enough to be reviewed as a separate > patch. > > The encode API allocates memory, because it fits our typical gc-oriented > code pattern and the caller does not have to do multiple calls or > calculations