[Openvpn-devel] [PATCH applied] Re: mbedtls: add RFC 5705 keying material exporter support

2020-01-19 Thread Gert Doering
Your patch has been applied to the master branch. I ran test builds on FreeBSD/mbedtls 2.16.3 (t_client test) and Gentoo/mbedtls 2.12.0 (t_server test), which pass. No tests were done with the crypto material exporter - have no test rig for it (but I wouldn't mind some easy to set up scripts

Re: [Openvpn-devel] [PATCH] mbedtls: add RFC 5705 keying material exporter support

2020-01-19 Thread Gert Doering
Hi, On Mon, Nov 11, 2019 at 02:12:04PM +0100, Arne Schwabe wrote: > Am 11.11.19 um 00:10 schrieb Steffan Karger: > > Since mbed TLS 2.18, mbed TLS can also implement RFC 5705. As a first > > step towards using the keying material exporter as a method to generate > > key material for the data

Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2020-01-19 Thread Gert Doering
Hi, On Sun, Jan 19, 2020 at 04:51:08PM +0100, Gert Doering wrote: > David, shall I just amend the patch, or do you want to resend a v3? > > (The other 3 of the set should be fine, as they do not touch tun.c) Not exactly correct, 2/4 renames all argv_reset() calls to argv_free(), so that *might*

Re: [Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2020-01-19 Thread Gert Doering
Hi, On Fri, Oct 04, 2019 at 07:12:43PM +0200, David Sommerseth wrote: > From: Heiko Hund > > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). Events have overtaken this

[Openvpn-devel] [PATCH applied] Re: wintun: refactor code to use enum driver type

2020-01-19 Thread Gert Doering
Your patch has been applied to the master branch. Test compiled on MingW/Ubuntu 16 (worked). Stared a bit at the code, most of it looks good and actually simplifies. The convoluted if() is something I'd like to see unwrapped - see other mail. commit 36215dc5c3e08a935392460ab236030d6d9cde8b

Re: [Openvpn-devel] [PATCH] wintun: refactor code to use enum driver type

2020-01-19 Thread Gert Doering
Hi, On Thu, Jan 16, 2020 at 03:19:00PM +0100, Simon Rozman wrote: > { > @@ -3676,14 +3692,16 @@ get_tap_reg(struct gc_arena *gc) > > if (status == ERROR_SUCCESS && data_type == REG_SZ) > { > -if (!strcmp(component_id, TAP_WIN_COMPONENT_ID)

[Openvpn-devel] [PATCH applied] Re: wintun: stop sending TAP-Windows6 ioctls to NDIS device

2020-01-19 Thread Gert Doering
Your patch has been applied to the master branch. Test compiled, and stared at the code a bit, seems to make sense :) commit 948b4f938a02dee78fb5246bcd44bc0162619b2d Author: Simon Rozman Date: Wed Jan 8 12:52:24 2020 +0100 wintun: stop sending TAP-Windows6 ioctls to NDIS device

[Openvpn-devel] [PATCH applied] Re: options.c: do not force route delay when not using DHCP

2020-01-19 Thread Gert Doering
Your patch has been applied to the master branch. (Stared a bit at the code, sounds reasonable, no testing whatsoever) commit dd4647acf40b26bb8d7403debc00a342c663d618 Author: Lev Stipakov Date: Thu Dec 19 15:29:53 2019 +0200 options.c: do not force route delay when not using DHCP