[Openvpn-devel] [PATCH] tls-crypt-v2: fix testing of inline key

2020-05-10 Thread Antonio Quartulli
The inline logic was recently changed by commit ("convert *_inline attributes to bool"), however the code testing a newly created tls-crypt-v2 client key was not adapted. Adapt tls-crypt-v2 test routine by properly signaling when the passed key is inlined or not. Signed-off-by: Antonio Quartulli

Re: [Openvpn-devel] [PATCH] get rid of TAG_FILE_INLINE constant

2020-05-10 Thread Antonio Quartulli
Hi, On 10/05/2020 15:53, David Sommerseth wrote: > This looks promising, but is not complete - and breaking compilation: > > > $ git grep INLINE_FILE_TAG > src/openvpn/tls_crypt.c:client_filename = INLINE_FILE_TAG; > > $ make -j5 > [...] > make[3]: Entering directory `/home/davids/deve

Re: [Openvpn-devel] [PATCH] get rid of TAG_FILE_INLINE constant

2020-05-10 Thread David Sommerseth
On 08/05/2020 23:23, Antonio Quartulli wrote: > Now that the whole inline logic has been converted to using bool flags, > the TAG_FILE_INLINE constant is not useful anymore. > > Get rid of the constant as it's now unused and to prevent any future > developer from mistakenly use it again. > > Sign

Re: [Openvpn-devel] [PATCH] options: fix inlining auth-gen-token-secret file

2020-05-10 Thread David Sommerseth
On 08/05/2020 23:14, Antonio Quartulli wrote: > With commit ("convert *_inline attributes to bool") the logic for > signaling when a certain option is inline has been changed. > Due to an overlook, the auth-gen-token-secret was not converted, thus > making it impossible to be inlined. > > Fix pars