Acked-by: Gert Doering
Documentation is good.
I have followed the advice from Nathan Stratton Treadway and looked a bit
into the wording, and added some text that I feel explains the process
and reasoning better (based on how you explained it to me). I hope it's
ok.
Your patch has been
Your patch has been applied to the master branch.
Haven't actually tested this in any server setup - but "this is your code,
if you say this is the way it needs to be, it is, the explanation makes
sense and the code change matches". An all other occurences use strlen()
as well... So,
Acked-by:
Your patch has been applied to the master branch. I have dutifully
fixed the "INLINE_FILE_TAG" confusion in the commit message :-)
Lightly compile-tested. Buildbot can do more testing (but this is one
of the patches that would break compilation anywhere, so "trivially
correct).
commit
Your patch has been applied to the master branch.
David beat me with the ACK - I had just advanced through my daily interrupt
load enough to be able to reproduce the problem ("testing the patch next!")
when the ACK arrived. Thanks anyway :-))
JFTR, after having created a tls-crypt-v2 server-key
On 08/05/2020 23:23, Antonio Quartulli wrote:
> Now that the whole inline logic has been converted to using bool flags,
> the TAG_FILE_INLINE constant is not useful anymore.
>
> Get rid of the constant as it's now unused and to prevent any future
> developer from mistakenly use it again.
>
>
On 10/05/2020 16:00, Antonio Quartulli wrote:
> The inline logic was recently changed by commit
> ("convert *_inline attributes to bool"), however the code testing a
> newly created tls-crypt-v2 client key was not adapted.
>
> Adapt tls-crypt-v2 test routine by properly signaling when the passed
Your patch has been applied to the master branch.
I have just done a compile test. Code change looks good.
commit 416162c5b66055da24e6e7b8acde4e7bb8f67522
Author: Antonio Quartulli
Date: Fri May 8 23:14:34 2020 +0200
options: fix inlining auth-gen-token-secret file
Signed-off-by:
