[Openvpn-devel] [PATCH applied] Re: Workaround FreeBSD 12+ race condition on tun/tap open with IPv6.

2020-08-23 Thread Gert Doering
Your patch has been applied to the master and release/2.5 branch. commit 5e19cc2c1bf22d44f10dc585ba69d48951dc7a86 (master) commit 6dac3342d851995bdee75db4b52cfb3a3f9232e3 (release/2.5) Author: Gert Doering Date: Thu Jul 23 14:19:49 2020 +0200 Workaround FreeBSD 12+ race condition on tun/ta

[Openvpn-devel] [PATCH applied] Re: Refactor key_state_export_keying_material functions

2020-08-23 Thread Gert Doering
Your patch has been applied to the master branch. I have no idea what this all does (and not enough brain power to develop interest in finding out :-/ ) but if Steffan says it's good, so it is. Also, t_client agrees :-) commit 10abd656a3ae279cea7344055ce23637b7a62f6b (master) Author: Arne Schwab

[Openvpn-devel] [PATCH applied] Re: Fixes a bug in management_callback_send_cc_message, should be strlen instead of sizeof

2020-08-23 Thread Gert Doering
I have not tested this, but the change is definitely "obviously correct" :) Your patch has been applied to the master and release/2.5 branch. commit 62560e2a29144ffefec231ae7147eb4e9c7dfebf (master) commit 6e1fccaa47c9376cf862219d98678345408c9a54 (release/2.5) Author: Eric Thorpe Date: Wed Aug

[Openvpn-devel] [PATCH applied] Re: Fix client's poor man NCP fallback

2020-08-23 Thread Gert Doering
I have not specifically tested the scenarios that this is fixing (due to time constraints and really poor Internet $here). I totally trust Steffan's review and Richard's testing, though, to fix the problem observed. I have run it through t_client tests (against git master servers about ~1 year

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-23 Thread tincanteksup
This is my suggestion for the commit message: -- This commit fixes two separate issues which are closely linked. First, a 2.5 client cannot connect to a server which does not support NCP and is not using one of the default --data-ciphers (AES-*-GCM). This is because the 2.5 client does not u

[Openvpn-devel] [PATCH applied] Re: tun.c: enable using wintun driver under SYSTEM

2020-08-23 Thread Gert Doering
Your patch has been applied to the master and release/2.5 branch. (I have not tested anything, but diffing tun.c to 6d19775a468~1 shows that's it is the same code that was removed, except for a more detailed error message) commit ed47c097db63f8334f32bf9482da488928ff909b (master) commit f4761dd12e