Re: [Openvpn-devel] [PATCH v3] Document common uses of 'echo' directive, re-enable logging for 'echo'.

2021-01-18 Thread Selva Nair
Hi. Looks good to me. The white- "space police" may object to the formatting in the logging code (see below). Could be fixed at commit time. On Mon, Jan 18, 2021 at 11:31 AM Gert Doering wrote: > > The 'echo' command can be used to signal information to an OpenVPN > GUI driving the openvpn core

[Openvpn-devel] [PATCH applied] Re: Skip DHCP renew with Wintun adapter

2021-01-18 Thread Gert Doering
Your patch has been applied to the master and release/2.5 branch. I've not tested it in any way, but looked at "git show -w", and this this makes it quite clear that the patch does not actually change as much code as it looks like, just moves the whole "dhcp_masq_post" code block into the "if (WIN

[Openvpn-devel] [PATCH applied] Re: Remove 1 second delay before running netsh

2021-01-18 Thread Gert Doering
Your patch has been applied to the master and releae/2.5 branch. I have not tested it, not even test compiled - but if Lev says it works, this is all we need :-) (As a side note: this reduces the *retry* delay on an error from 5 seconds to 4 seconds now - which should not make any interesting dif

[Openvpn-devel] [PATCH applied] Re: Clarify --block-ipv6 intent and direction.

2021-01-18 Thread Gert Doering
Patch has been applied to the master and release/2.5 branch. The commit message has been fixed (option -> direction) as discussed. commit 8a8ee283aa7a4b409a9dafc082a6c65b5539308b (master) commit 490203e6a7594ed946fe3158a694f80be2c18c9c (release/2.5) Author: Gert Doering Date: Fri Dec 25 17:42:1

[Openvpn-devel] [PATCH v3] Document common uses of 'echo' directive, re-enable logging for 'echo'.

2021-01-18 Thread Gert Doering
The 'echo' command can be used to signal information to an OpenVPN GUI driving the openvpn core via management interface. Which commands exists and their syntax has so far been mostly undocumented. Condense the long and good discussion between Selva Nair and Jonathan K. Bullard into doc/gui-notes

Re: [Openvpn-devel] [PATCH v2] Document common uses of 'echo' directive, re-enable logging for 'echo'.

2021-01-18 Thread Selva Nair
Hi, On Mon, Jan 18, 2021 at 8:17 AM Gert Doering wrote: > > There will be a v3, as I just added "Android: Planned" to all the > msg stuff. > > Selva, which GUI version will be "the one with msg support"? So I can > have this fixed as well. GUI is at 11.21.0 right now, this will be in 11.22.0 to

Re: [Openvpn-devel] [PATCH v2] Document common uses of 'echo' directive, re-enable logging for 'echo'.

2021-01-18 Thread Gert Doering
Hi, On Mon, Jan 18, 2021 at 01:15:29PM +0100, Gert Doering wrote: > v2: > incorporate feedback from Selva Nair, correct >ECHO examples There will be a v3, as I just added "Android: Planned" to all the msg stuff. Selva, which GUI version will be "the one with msg support"? So I can have this f

[Openvpn-devel] [PATCH v2] Document common uses of 'echo' directive, re-enable logging for 'echo'.

2021-01-18 Thread Gert Doering
The 'echo' command can be used to signal information to an OpenVPN GUI driving the openvpn core via management interface. Which commands exists and their syntax has so far been mostly undocumented. Condense the long and good discussion between Selva Nair and Jonathan K. Bullard into doc/gui-notes

[Openvpn-devel] [PATCH applied] Re: Zero initialise msghdr prior to calling sendmesg

2021-01-18 Thread Gert Doering
I have adjusted the whitespace as requested by Antonio, and added your SoB-Line (as agreed on IRC). Your patch has been applied to the master, and release/2.5 branch (bugfix). I have not merged it to 2.4 - it would nicely fit, but since this is all TARGET_ANDROID, and nobody builds the Android c