[Openvpn-devel] [PATCH applied] Re: Replace OS_SPECIFIC_DIRSEP with PATH_SEPARATOR

Acked-by: Gert Doering I have not actually tested it (only test compiled on the unix zoo and MinGW), but it looks very reasonable. Your patch has been applied to the master branch. commit d4c1a453c2084fa09baeee58cda0a9823e0b5038 Author: Arne Schwabe Date: Thu Apr 22 17:29:38 2021 +0200

[Openvpn-devel] [PATCH applied] Re: Move direct.h header where it is used

Acked-by: Gert Doering I seemed to remember having used before on "something not WIN32" - and yeah, this was part of the DOS compat layer on SCO Unix :-) .. which we certainly do not use. So, makes sense. Your patch has been applied to the master branch. commit 8c18d7c9323084d1b346ea303cf8cfd

[Openvpn-devel] [PATCH applied] Re: Remove a number of platform specific checks in configure.ac

Acked-by: Gert Doering Changes look good and have been tested on the Unix zoo and MinGW/Ubuntu 18. Your patch has been applied to the master branch. commit ba49c9a7bf7dfeea181b5f18a921a5d29c9b10b3 Author: Arne Schwabe Date: Thu Apr 22 17:29:39 2021 +0200 Remove a number of platform spec

[Openvpn-devel] [PATCH applied] Re: Avoid failing_test unused warning in example_test

Acked-by: Gert Doering Acked-by: Gert Doering This might break compilation of the example test on non-gcc/clang platforms. I do not have one at hand, though - my OpenSolaris box has no Sun CC, so is using gcc... and on AIX, I do not compile the test suite anyway (no cmocka). So this might co

Re: [Openvpn-devel] [PATCH v2 4/6] Remove support for blocking connect()

Hi, On Thu, Apr 22, 2021 at 05:29:37PM +0200, Arne Schwabe wrote: > It is hard to imagine that we still have any supported OS that does > not support non-blocking connect while still supporting non-blocking > sockets in general. > > Patch V2: remove epoll.h removal that should have been in other

Re: [Openvpn-devel] [PATCH v2 2/6] Remove --disable-multihome option

Hi, On Thu, Apr 22, 2021 at 05:29:35PM +0200, Arne Schwabe wrote: > With this change we always build multihome support if the operating > system supports it. > > Patch v2: Remove also from config-msvc.h > diff --git a/configure.ac b/configure.ac > index 747325164..aaac65c3d 100644 > --- a/config

[Openvpn-devel] Adding RSA-PSS support in pkcs11-helper

Hi, Currently RSA-PSS signatures are handled in pkcs11-helper by asking the token to do raw RSA signature of data already padded by OpenSSL. Many new hardware tokens refuse to support this mode and require the padding to be done in hardware. For a recent user report see this thread: https://www.m

[Openvpn-devel] [PATCH applied] Re: windows: list all enum values in switch block

Your patch has been applied to the master branch. commit f20c377c65f499595939f8a0910f7d7b062b6894 Author: Antonio Quartulli Date: Sat May 1 15:06:40 2021 +0200 windows: list all enum values in switch block Signed-off-by: Antonio Quartulli Acked-by: Arne Schwabe Message-Id

[Openvpn-devel] [PATCH applied] Re: windows: define variable only where used

Your patch has been applied to the master branch. commit 00c36948297654d93174aed1f8244e6e6734e141 Author: Antonio Quartulli Date: Sat May 1 15:06:39 2021 +0200 windows: define variable only where used Signed-off-by: Antonio Quartulli Acked-by: Arne Schwabe Message-Id: <20

[Openvpn-devel] [PATCH applied] Re: windows: use appropriate and portable format specifier for 64bit pointer

Your patch has been applied to the master branch. commit 396c4e4903fda078536016b7ada97862f713bd94 Author: Antonio Quartulli Date: Sat May 1 15:06:38 2021 +0200 windows: use appropriate and portable format specifier for 64bit pointer Signed-off-by: Antonio Quartulli Acked-by: Ar

[Openvpn-devel] [PATCH applied] Re: Add documentation on EVENT_READ/EVENT_WRITE constants

I've done a quick stare-on-code and ran the client side tests on FreeBSD, and all worked. Your patch has been applied to the master branch. commit c2912912047fdd228faedb6466672288e14dbba6 Author: Antonio Quartulli Date: Tue Apr 27 21:13:14 2021 +0200 Add documentation on EVENT_READ/EVENT_

Re: [Openvpn-devel] [PATCH v5] Add documentation on EVENT_READ/EVENT_WRITE constants

Am 27.04.21 um 21:13 schrieb Antonio Quartulli: > From: Antonio Quartulli > > Changes from v4: > - get rid of the overly complex EVENT_SHIFT() macro > > Changes from v3: > - re-introduce READ/WRITE_SHIFT because they are different from > EVENT_READ/WRITE > - define also EVENT_READ/WRITE using R

Re: [Openvpn-devel] [PATCH 1/3] windows: use appropriate and portable format specifier for 64bit pointer

Am 01.05.21 um 15:06 schrieb Antonio Quartulli: > From: Antonio Quartulli > > To print a 64bit poiner, fprintf() must be provided with the appropriate > format specifier. > > The most portable in this case is PRIx64, which is redefined accordingly > on each platform. It comes from inttypes.h and

Re: [Openvpn-devel] [PATCH 2/3] windows: define variable only where used

Am 01.05.21 um 15:06 schrieb Antonio Quartulli: > From: Antonio Quartulli > > warn_used is a static variable but that is used only under certain > conditions. These conditions do not apply for Windows and therefore > mingw is spitting a warning for unused variable. > > Move variable declaration

Re: [Openvpn-devel] [PATCH 3/3] windows: list all enum values in switch block

Am 01.05.21 um 15:06 schrieb Antonio Quartulli: > From: Antonio Quartulli > > A switch block in interactive.c is missing the _undo_type_max value > of the neum set, thus triggering a compiler warning. > > Due to the logic, this value cannot really be assigned to the variable > being examinated,