[Openvpn-devel] [PATCH] Add git pre-commit hook script to uncrustify

2022-04-20 Thread Heiko Hund
The script is self installing if you call it with "install" as the first parameter. Once installed as the pre-commit hook it will check files to be committed according to the rules in uncrustify.conf and abort the commit if there's formatting issues. The script produces a patch in /tmp which can be

[Openvpn-devel] [PATCH] The Great Reformatting of 2022

2022-04-20 Thread David Sommerseth
From: David Sommerseth It was agreed it was time to do a full reformat fix-up of the whole source tree again. Over time (since late 2016) small changes has not adhered to our uncrustify defined coding style. This realigns to our current standards. Signed-off-by: David Sommerseth --- Note: On

[Openvpn-devel] [PATCH 1/3] dev-tools: Remove no longer needed openvpn-plugin.h.in patching

2022-04-20 Thread David Sommerseth
From: David Sommerseth The bug in uncrustify 0.64 is no longer causing us issues as we now require at least v0.72. This workaround was added as part of the initial reformat-all inclusion, in commit 2417d55c4945d491e. Signed-off-by: David Sommerseth --- .../after_include_openvpn-plugin.h.in.pa

[Openvpn-devel] [PATCH 3/3] dev-tools: Avoid uncrustify mangling MAC_FMT macro

2022-04-20 Thread David Sommerseth
From: David Sommerseth The MAC_FMT in src/openvpn/misc.h need to be formatted strictly, and uncrustify does not fully grasp the current code. So we tell it to not touch it. Signed-off-by: David Sommerseth --- src/openvpn/misc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn

[Openvpn-devel] [PATCH 2/3] dev-tools: Remove uncrusify -p

2022-04-20 Thread David Sommerseth
From: David Sommerseth The -p option to uncrustify was providing debug information about decisions done by uncrustify. This was useful when debugging why certain formatting choices. With newer versions of uncrusitfy the -p option can only be used on individual files and not a list of files. Si

Re: [Openvpn-devel] :openvpn dco connection problem

2022-04-20 Thread Arne Schwabe
Am 20.04.22 um 10:18 schrieb yuanxun: Hi I recently encountered a bug when using the openvpn dco branch. When the client connection reaches max_cliants, I reconnect one of the clients, and the client will fail to reconnect when it reaches the set number of reconnections. At this time, the cli

Re: [Openvpn-devel] Fix links to client docs

2022-04-20 Thread David Sommerseth
On 19/04/2022 15:09, David Schneider wrote: Hello This is my first contribution to this project. As stated in the README patches should be sent to the mailing list. Here is a small change to fix the wrong path to the client docs page. Please let me know if the patch should be submitted in any

[Openvpn-devel] :openvpn dco connection problem

2022-04-20 Thread yuanxun
Hi I recently encountered a bug when using the openvpn dco branch. When the client connection reaches max_cliants, I reconnect one of the clients, and the client will fail to reconnect when it reaches the set number of reconnections. At this time, the client state is Not connected, but on the mana