[Openvpn-devel] [PATCH applied] Re: dco: properly name variables

2022-08-14 Thread Gert Doering
Acked-by: Gert Doering Thanks for that. This really helps understanding which address is which. Mechanical rename, so "trivial", but still tested on the Linux DCO test rig :-) Interesting enough, uncrustify did not catch this whitespace error +vpn_ip4.s_addr = htonl(c->c2.push_ifconf

Re: [Openvpn-devel] [PATCH] Allow querying DCO status via management status

2022-08-14 Thread Lev Stipakov
Hi, Code looks good and does what it says - tested on Linux with --status-version 2 and sending SIGUSR2. Is the first line of the commit message ("Allow querying DCO status via management status") descriptive enough? Since the change allows users to see DCO status without a management interface,

[Openvpn-devel] [PATCH v103 6/7] dco-win: ensure the DCO API is not used when running on Windows

2022-08-14 Thread Antonio Quartulli
On Windows the high level API should still use the link_socket object to read and write packets. For this reason, even if dco_installed is true, we still need to rely on the classic link_socket object. Signed-off-by: Antonio Quartulli --- Changes from v102: * mark helper as 'inline' * improve com

[Openvpn-devel] [PATCH applied] Re: error.c: remove unused crash() function

2022-08-14 Thread Gert Doering
Acked-by: Gert Doering Dead code indeed. And if we want to crash, we can do this without help! Test compiled on Linux. Your patch has been applied to the master branch. commit 1e1ec038168f22afa584aea79a0323a9fdf45095 Author: Lev Stipakov Date: Sun Aug 14 00:20:40 2022 +0300 error.c: r

Re: [Openvpn-devel] [PATCH v102 6/7] dco-win: ensure the DCO API is not used when running on Windows

2022-08-14 Thread Lev Stipakov
Hi, > On Windows the high level API should still use the link_socket object to > read and write packets. For this reason, even if dco_installed is true, > we still need to rely on the classic link_socket object. This is true. > > + * > + * Windows DCO needs control packets to be sent via the nor