The patch basically removes the !defined(ENABLE_CRYPTO_WOLFSSL) from
this part of the ifdef and that breaks wolfSSL. While I don't think we
should much effort into wolfSSL, we should also not break it on purpose.
Arne
You told me to ignore it in IRC. But sure, I can make a v3.
Ignore but
From: Antonio Quartulli
With this change it is possible to use ovpn-dco-win when running OpenVPN
in client or P2P mode.
Signed-off-by: Arne Schwabe
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio Quartulli
---
Changes from v101:
* move tuntap_is_dco_win() check from init.c to open_tun()
During review/update phase, FreeBSD/DCO's ability to find the first
free tun interface on "--dev tun" got broken, due to two issues:
- create_interface() called msg(M_ERR|...), which is a fatal error
and aborts OpenVPN, so "no retry with 'tun1' after 'tun0' failed"
Change to
Hi,
On Fri, Aug 19, 2022 at 07:04:42PM +0200, Gert Doering wrote:
> I had to apply a bit of pressure to get the patch to apply - it had
> one hunk trying to fix an #endif which never existed :-) - and the context
> of the last tun.c hunk needed adjustment (if (tun_dco_enabled(tt))) -
> both
Hi,
On Fri, Aug 12, 2022 at 03:41:52PM +0200, Kristof Provost via Openvpn-devel
wrote:
> Here's the updated version of the FreeBSD DCO patch. It should address
> all remarks on the userspace side of things.
As I said, I only tested the client side of things so far. Now I started
building a
I had to apply a bit of pressure to get the patch to apply - it had
one hunk trying to fix an #endif which never existed :-) - and the context
of the last tun.c hunk needed adjustment (if (tun_dco_enabled(tt))) -
both fairly trivial, and no actual code change.
Pushed to the new and renovated
Acked-by: Gert Doering
I had to apply a bit of pressure to get the patch to apply - the
context in tun.c got changed ( || TARGET_FREEBSD) in the meantime...
fairly trivial, and no actual code change.
Pushed to the new and renovated buildbot army, to see if it would break
any platforms (very
> -Original Message-
> From: Arne Schwabe [mailto:a...@rfc2549.org]
> Sent: donderdag 18 augustus 2022 22:16
> To: Maximilian Fillinger ; openvpn-
> de...@lists.sourceforge.net
> Subject: Re: [Openvpn-devel] [PATCH v2 1/2] Update openssl_compat.h for
> newer LibreSSL
>
> Am 11.08.22 um
Sorry for leaving this ACKed-but-unmerged since July. It got heaped-over
by DCO patches...
Anyway. I have no current test rig where I could recreate and test this,
but if Arne as resident management interface expert is happy with this,
this is fine for me. (The comment / message updates are
Current exit notification relies on data channel messages with specific
prefix. Adding these to new data channel modules (DCO) adds unncessary
complexity for the data for messages that from their idea belong to the
control channel anyway.
This patch adds announcing support for control channel and
On Freitag, 19. August 2022 11:51:32 CEST Arne Schwabe wrote:
> +verify_crresponse_script(struct tls_multi *multi, const char *cr_response)
> +{
[...]
> +if (!status_close(so))
> +{
> +msg(D_TLS_ERRORS, "TLS CR Response Error: could not write cr"
> +
Hi,
Regarding testing - if ordex could rebase and push dco branch, I could
start a fresh openvpn-build on GHA to build Windows installers with
dco. Here are MSI installers build with 6 days old dco branch:
https://github.com/OpenVPN/openvpn-build/actions/runs/2815957952
pe 19. elok. 2022 klo
Hi,
I remember someone was explaining to me the necessity of verbose
commit messages.
Chi può essere?
> It seems to take an existing setup that builds an installer *with* DCO,
> and remove the DCO bits?
> ... so maybe we can have a better commit message that explains this?
We decided to move
Hi,
this looks good to me - will apply as soon as 3/7 goes in (to avoid
having documentation that says "it's in" while it isn't).
Acked-By: Gert Doering
On Sat, Aug 13, 2022 at 10:42:21PM +0200, Antonio Quartulli wrote:
> Signed-off-by: Arne Schwabe
> Signed-off-by: Lev Stipakov
>
Hi,
On Sat, Aug 13, 2022 at 10:42:22PM +0200, Antonio Quartulli wrote:
> Signed-off-by: Lev Stipakov
> Signed-off-by: Antonio Quartulli
> ---
> .github/workflows/build.yaml | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
I do not understand this commit. Not at all.
It seems to
Hi,
On Fri, Aug 19, 2022 at 11:50:04AM +0200, Arne Schwabe wrote:
> Am 18.08.22 um 22:43 schrieb Antonio Quartulli:
> > yes! This is what we need!
> >
> > Acked-by: Antonio Quartulli
>
> I am out of the loop here. Could you two explain why we need this? I.e.
> what is wrong with the current
Hi,
On 19/08/2022 11:50, Arne Schwabe wrote:
Am 18.08.22 um 22:43 schrieb Antonio Quartulli:
yes! This is what we need!
Acked-by: Antonio Quartulli
I am out of the loop here. Could you two explain why we need this? I.e.
what is wrong with the current style is and what the plan is to
Hi,
On Sat, Aug 13, 2022 at 10:42:20PM +0200, Antonio Quartulli wrote:
> With this change it is possible to use ovpn-dco-win when running OpenVPN
> in client or P2P mode.
>
> Signed-off-by: Arne Schwabe
> Signed-off-by: Lev Stipakov
> Signed-off-by: Antonio Quartulli
All the prerequisites
This is allows scripts and pluginsto parse/react to a CR_RESPONSE message
Patch V2: doc fixes, do not put script under ENABLE_PLUGIN
Patch V3: rebase
Patch V4: fix else branch of the verify_crresponse_script function
Signed-off-by: Arne Schwabe
---
doc/man-sections/script-options.rst | 28
Am 18.08.22 um 22:43 schrieb Antonio Quartulli:
yes! This is what we need!
Acked-by: Antonio Quartulli
I am out of the loop here. Could you two explain why we need this? I.e.
what is wrong with the current style is and what the plan is to change?
If often struggle to properly format
Acked-by: Gert Doering
"This one is better" :-)
Test built via GHA for MSVC, tested on Linux non-DCO / DCO client and
DCO server. This time, neither "non DCO" nor "DCO build" exhibited
any surprises (as expected).
Not tested actual Windows build, but the checks match the commit
message (and
On Donnerstag, 18. August 2022 19:20:33 CEST Gert Doering wrote:
> On Thu, Aug 18, 2022 at 04:39:07PM +0200, Heiko Hund wrote:
> > On Freitag, 20. Mai 2022 23:32:48 CEST Arne Schwabe wrote:
> > > Patch V2: remove uncessary ifdef/endif and unnecassary block
> >
> > Acked-by: Heiko Hund
>
>
At the moment dco-win doesn't support --persist-tun and --server,
so check for these options at startup time.
Signed-off-by: Antonio Quartulli
Signed-off-by: Lev Stipakov
---
Changes from v103:
* fix ifdef condition (use || instead of &&) in options.c
Changes from v102:
* remove platform
23 matches
Mail list logo
