Re: [Openvpn-devel] [PATCH] DCO: require valid netbits setting for non-primary iroutes.

2022-08-23 Thread Antonio Quartulli
Hi, On 20/08/2022 16:01, Gert Doering wrote: The existing DCO code had extra logic for "if this is not MR_WITH_NETBITS, set 32/128 as address length", but only for iroute addition. For iroute deletion, this was missing, and subsequently iroute deletion for IPv4 host routes failed on FreeBSD

Re: [Openvpn-devel] [PATCH applied] Re: Update openssl_compat.h for newer LibreSSL

2022-08-23 Thread Arne Schwabe
Am 23.08.22 um 20:55 schrieb Gert Doering: Hi, On Tue, Aug 23, 2022 at 10:21:30AM +, Maximilian Fillinger wrote: I'm a bit unsure if we need this for 2.5 - it's "long term compat" and not very intrusive, but on the other hand, not too many people seem to care about LibreSSL. OpenBSD has

Re: [Openvpn-devel] [PATCH] t_client.sh: do not require fping6

2022-08-23 Thread Antonio Quartulli
Hi, On 22/08/2022 16:18, Frank Lichtenheld wrote: fping and fping6 were merged in version 4.0, released in 2017. Many recent distributions do not include the compatibility symlink anymore. So if we find fping but not fping6 do not error out but assume that fping is capable of IPv6.

Re: [Openvpn-devel] [PATCH applied] Re: Update openssl_compat.h for newer LibreSSL

2022-08-23 Thread Gert Doering
Hi, On Tue, Aug 23, 2022 at 10:21:30AM +, Maximilian Fillinger wrote: > > I'm a bit unsure if we need this for 2.5 - it's "long term compat" > > and not very intrusive, but on the other hand, not too many people > > seem to care about LibreSSL. > > OpenBSD has packaged 2.5.7 for snapshots,

Re: [Openvpn-devel] [PATCH applied] Re: Allow a few levels of recursion in virtual_output_callback()

2022-08-23 Thread Gert Doering
Hi, On Tue, Aug 02, 2022 at 02:02:39PM +0200, Gert Doering wrote: > Your patch has been applied to the master branch. > > commit 4dfd592ff1ee18aa4859264c8a341dfa1a291988 ... and after some reminding, to release/2.5 as well. commit 468f53ae3bfcfca6563acbf648e7a0bc6f94b038 (HEAD -> release/2.5)

Re: [Openvpn-devel] [PATCH applied] Re: Allow a few levels of recursion in virtual_output_callback()

2022-08-23 Thread Gert Doering
Hi, On Mon, Aug 22, 2022 at 10:43:39PM -0400, Selva Nair wrote: > In case this request was lost, here goes again. Can we have this > cherry-picked into 2.5 before the next release? Oops. It got lost, was rediscovered last week, and got lost again. Sorry, and thanks for the reminder. gert --

Re: [Openvpn-devel] [PATCH v2] GitHub Actions: Use Docker Images for Ubuntu test runs

2022-08-23 Thread Timo Rothenpieler
On 23/08/2022 15:42, Timo Rothenpieler wrote: +run: docker exec ovpn -e DEBIAN_FRONTEND=noninteractive sh -c "apt update && apt install -y liblzo2-dev libpam0g-dev liblz4-dev libcap-ng-dev linux-libc-dev man2html libcmocka-dev python3-docutils build-essential pkgconf libtool automake

[Openvpn-devel] [PATCH v2] GitHub Actions: Use Docker Images for Ubuntu test runs

2022-08-23 Thread Timo Rothenpieler
The ubuntu-18.04 base image is deprecated and in the process of being phased out: https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ It is already causing build failures during the scheduled periods

Re: [Openvpn-devel] [PATCH] GitHub Actions: Use Docker Images for Ubuntu test runs

2022-08-23 Thread Frank Lichtenheld
On Tue, Aug 23, 2022 at 02:09:02PM +0200, Timo Rothenpieler wrote: > The ubuntu-18.04 base image is deprecated and in the process of being phased > out: >

Re: [Openvpn-devel] [PATCH v103] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-23 Thread Lev Stipakov
Another feedback - I asked our corp QA engineer to give this build a try, here are results: --- Testing OpenVPN GUI on Windows 11: - install, remove and upgrade from 2.5.7 to https://github.com/lstipakov/openvpn-build/actions/runs/2902240643 - Connection with `DCO` via autologin, user-locked,

[Openvpn-devel] [PATCH] GitHub Actions: Use Docker Images for Ubuntu test runs

2022-08-23 Thread Timo Rothenpieler
The ubuntu-18.04 base image is deprecated and in the process of being phased out: https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ It is already causing build failures during the scheduled periods

Re: [Openvpn-devel] [PATCH applied] Re: Update openssl_compat.h for newer LibreSSL

2022-08-23 Thread Maximilian Fillinger
> I'm a bit unsure if we need this for 2.5 - it's "long term compat" > and not very intrusive, but on the other hand, not too many people > seem to care about LibreSSL. OpenBSD has packaged 2.5.7 for snapshots, so they must already have a workaround.

Re: [Openvpn-devel] [PATCH] DCO: require valid netbits setting for non-primary iroutes.

2022-08-23 Thread Kristof Provost via Openvpn-devel
On 20 Aug 2022, at 16:01, Gert Doering wrote: > The existing DCO code had extra logic for "if this is not > MR_WITH_NETBITS, set 32/128 as address length", but only for > iroute addition. For iroute deletion, this was missing, and > subsequently iroute deletion for IPv4 host routes failed on >