[Openvpn-devel] [PATCH applied] Re: Check if pkcs11_cert is NULL before freeing it

2022-11-23 Thread Gert Doering
Confirmed that it crashes without the patch, and does not crash with it. Added a comment, as suggested. Your patch has been applied to the master and release/2.5 branch (bugfix). commit 19c64f16baebbce966d55c62135d1ef066f7c8c2 (master) commit 4f5e57d2c7ff9384b16c42eb9aa5af11d31f5dd1 (release/2.5

Re: [Openvpn-devel] [PATCH] Check if pkcs11_cert is NULL before freeing it

2022-11-23 Thread Gert Doering
Hi, On Wed, Nov 23, 2022 at 01:37:47PM -0500, Selva Nair wrote: > pkcs11h_certiciate_freeCertificate() does seem to handle NULL argument. > With --show-tls, are we calling this before intializing the pkcs11 library? > That could trigger an ASSERT. If I build on Linux with mbedtls && --enable-pkcs

Re: [Openvpn-devel] [PATCH] Check if pkcs11_cert is NULL before freeing it

2022-11-23 Thread Selva Nair
Hi, On Wed, Nov 23, 2022 at 12:18 PM Arne Schwabe wrote: > Am 23.11.22 um 16:49 schrieb Max Fillinger: > > When running openvpn --show-tls with mbedtls, it showed a null pointer > > error at the end because of this. > > > > Signed-off-by: Max Fillinger > > --- > > src/openvpn/ssl_mbedtls.c |

Re: [Openvpn-devel] [PATCH] Check if pkcs11_cert is NULL before freeing it

2022-11-23 Thread Arne Schwabe
Am 23.11.22 um 16:49 schrieb Max Fillinger: When running openvpn --show-tls with mbedtls, it showed a null pointer error at the end because of this. Signed-off-by: Max Fillinger --- src/openvpn/ssl_mbedtls.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/openvpn/

[Openvpn-devel] [PATCH] Check if pkcs11_cert is NULL before freeing it

2022-11-23 Thread Max Fillinger
When running openvpn --show-tls with mbedtls, it showed a null pointer error at the end because of this. Signed-off-by: Max Fillinger --- src/openvpn/ssl_mbedtls.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index

Re: [Openvpn-devel] [PATCH v2 1/3] Move dco_installed from sock->info to sock->info.lsa.actual

2022-11-23 Thread Gert Doering
Hi, On Wed, Oct 26, 2022 at 06:45:22PM +0200, Arne Schwabe wrote: > For tcp this makes no difference as the remote address of the > socket never changes. For udp this allows OpenVPN to differentiate > if a reconnecting client is using the same address as before or > from a different one. This allo

Re: [Openvpn-devel] [PATCH v2 1/3] Move dco_installed from sock->info to sock->info.lsa.actual

2022-11-23 Thread Antonio Quartulli
Hi, On 26/10/2022 18:45, Arne Schwabe wrote: For tcp this makes no difference as the remote address of the socket never changes. For udp this allows OpenVPN to differentiate if a reconnecting client is using the same address as before or from a different one. This allow sending via the normal us