Re: [Openvpn-devel] [PATCH] dco: print proper message in case of transport disconnection

2023-01-12 Thread Gert Doering
Hi, On Thu, Jan 12, 2023 at 12:50:52AM +0100, Antonio Quartulli wrote: > diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c > index 77dcaa60..99123c39 100644 > --- a/src/openvpn/multi.c > +++ b/src/openvpn/multi.c > @@ -3244,6 +3244,10 @@ process_incoming_del_peer(struct multi_context *m, >

[Openvpn-devel] OpenVPN 2.6_rc2 released

2023-01-12 Thread Frank Lichtenheld
The OpenVPN community project team is proud to release OpenVPN 2.6_rc2. This is the second release candidate (and the fourth beta release) for the feature release 2.6.0. Changes since RC1: * Add rate limiter for incoming "initial handshake packets", enabled by default with a limit of 100

[Openvpn-devel] [PATCH] Workaround: make ovpn-dco more reliable

2023-01-12 Thread Arne Schwabe
This workaround avoids the kernel trigger ENOBUFS when the kernel internal queue is overrun with events of disconnectingh clients or similar. This is a workaround until we come up with a more permanent solution. Signed-off-by: Arne Schwabe --- src/openvpn/dco_linux.c | 5 + 1 file changed,

Re: [Openvpn-devel] [PATCH] dco: send SIGUSR1 upon ping timeout

2023-01-12 Thread Gert Doering
Hi, On Thu, Jan 12, 2023 at 02:52:33AM +0100, Arne Schwabe wrote: > Am 12.01.23 um 01:04 schrieb Antonio Quartulli: > > Arne, I am not 100% sure why but it seems for ping-restart we always use > > SIGUSR1, right? but the DCO handling code was apparently using SIGTERM. > > > > What do you think?

[Openvpn-devel] [PATCH applied] Re: dco: print proper message in case of transport disconnection

2023-01-12 Thread Gert Doering
As discussed on IRC, there will be another patch with a license change "really soon now". THIS patch is important to get into rc2, so people can test new kernel modules and get proper DCO exit code reporting. The patch itself is trivial ("compile tested so it won't accidentially break

Re: [Openvpn-devel] [PATCH] dco: print proper message in case of transport disconnection

2023-01-12 Thread David Sommerseth
On 12/01/2023 09:43, Lev Stipakov wrote: Hi, -/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ This specific hunk is beyond my pay grade. I dug into this. License wise, GPL-2.0 is the same as GPL-2.0-only

Re: [Openvpn-devel] [PATCH] dco: print proper message in case of transport disconnection

2023-01-12 Thread Arne Schwabe
Am 12.01.23 um 09:43 schrieb Lev Stipakov: Hi, -/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ This specific hunk is beyond my pay grade. And we should change it. Currently that header file is incompatible

Re: [Openvpn-devel] [PATCH] dco: print proper message in case of transport disconnection

2023-01-12 Thread Lev Stipakov
Hi, > -/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ This specific hunk is beyond my pay grade. Otherwise looks good, I tested it with the latest dco master and got a proper error message: >