Hi,
Is this dependent on some patch not yet merged? See missing context below.
On Tue, May 16, 2023 at 12:36 PM Arne Schwabe wrote:
> the management interface expects the management key id instead
> of the openvpn key id. In the past they often were the same for low ids
> which hid the bug
the management interface expects the management key id instead
of the openvpn key id. In the past they often were the same for low ids
which hid the bug quite well.
Also do not pick uninitialised keystates (management key_id is not valid
in these) and provide better logging when a key state is
Acked-by: Gert Doering
Looks good. Existing tests still work (tested in-tree and out-of-tree
builds, but in the end that's both "../src/openvpn/openvpn")
"make check openvpn=$path/openvpn" also runs the specified binary.
Your patch has been applied to the master branch.
(Since most
The OpenVPN community project team is proud to release OpenVPN 2.6.4.
This is a small bugfix release.
Note:
* License amendment: all NEW commits fall under a modified license that
explicitly permits
linking with Apache2 libraries (mbedTLS, OpenSSL).
See COPYING for details. Existing code
On Tue, May 16, 2023 at 01:21:34PM +0200, Gert Doering wrote:
> Explanation makes sense, though it's only relevant for "outside openvpn GUI"
> use cases. But I look forward to a submission of "openvpn windows CLI" :-)
>
> Test compiled on MinGW. Does our GH windows test setup use the event
>
Am 15.05.23 um 19:26 schrieb Jeremie Courreges-Anglas:
On Wed, Apr 26 2023, Arne Schwabe wrote:
After first round of mailing people with more than 10 commits we have
almost all committers have agreed. This put this license in the realm
of having a realistic change to work. Had any of these
Explanation makes sense, though it's only relevant for "outside openvpn GUI"
use cases. But I look forward to a submission of "openvpn windows CLI" :-)
Test compiled on MinGW. Does our GH windows test setup use the event
mechanism? Or "classic signals"?
Your patch has been applied to the
Hi,
My understanding is that this is related to
https://github.com/OpenVPN/openvpn-gui/issues/626#issuecomment-1546934297
since normally we use string representation of HANDLE value
as an event name.
Looks good to me. Also compiled and tested.
Acked-by: Lev Stipakov
ti 16. toukok. 2023 klo
Acked-by: Gert Doering
I do not really think this is *necessary* (if malloc() fails for a
few bytes, how relevant are these free() calls, and how likely is that
the next malloc() inside OpenVPN will just make everything stop?) - but
it's good practice, and if it silences semi-irrelevant
Acked-by: Gert Doering
"Quite obvious, if you look at it" :-) - since one of this is Windows,
I have at least compile-tested this on MinGW.
Your patch has been applied to the master and release/2.6 branch.
commit b5cf76cbdc0d7ef2817b71f4611d99455e2d48ea (master)
commit
I was looking for memleaks in the code and found
this one with cppcheck. Only an example, but no
need to leave this bug in it.
Also fix fortify problem in keying-material-exporter-demo
so I can actually test the compilation of the sample
plugins.
v2:
- remove unneccessary usages of snprintf,
Good catch!
I have done a basic "does it still compile and not crash?" test on the
server-with-DCO test rig. Does not crash :-) - and the patch looks good.
Your patch has been applied to the master and release/2.6 branch.
commit 276f7c86d70666bc2ab4e6192ef5f1dcbd6a230f (master)
commit
12 matches
Mail list logo
