Re: [Openvpn-devel] [PATCH 2/2] Implement using --peer-fingerprint without CA certificates

2023-06-30 Thread Arne Schwabe
Am 30.06.23 um 15:31 schrieb Maximilian Fillinger: The grammar in the 3rd sentence in the comment below is messed up. (I think I understand it, but I'm not sure.) +if (session->opt->verify_hash_no_ca) +{ +/* + * If we decide to verify the peer certificate based on the

Re: [Openvpn-devel] [PATCH 2/2] Implement using --peer-fingerprint without CA certificates

2023-06-30 Thread Maximilian Fillinger
The grammar in the 3rd sentence in the comment below is messed up. (I think I understand it, but I'm not sure.) > +if (session->opt->verify_hash_no_ca) > +{ > +/* > + * If we decide to verify the peer certificate based on the > fingerprint > + * we ignore wrong

[Openvpn-devel] [PATCH] test_tls_crypt: Improve mock() usage to be more portable

2023-06-30 Thread Frank Lichtenheld
Use the casting variants of mock(). Using the mock_ptr_type fixes an existing bug where test_tls_crypt.c couldn't build in MinGW 32bit: test_tls_crypt.c:127:27: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 127 | const char *pem_str = (const char *)

Re: [Openvpn-devel] [PATCH 1/4] Do not blindly assume python3 is also the interpreter that runs rst2html

2023-06-30 Thread Frank Lichtenheld
On Thu, Jun 29, 2023 at 11:56:07PM +0200, Arne Schwabe wrote: > On my system python3 is the macOS system python3 while rst2html has > >#!/opt/homebrew/opt/python@3.9/bin/python3.9 > > as its first line. Running that with a different python results in missing > python modules. So directly

Re: [Openvpn-devel] [PATCH 4/4] Avoid unused function warning/error on FreeBSD

2023-06-30 Thread Frank Lichtenheld
On Thu, Jun 29, 2023 at 11:56:11PM +0200, Arne Schwabe wrote: > the funktion is_on_link is not used on FreeBSD and triggers a > warning/error (-Werror) on FreeBSD. > > Change-Id: I6757d6509ff3ff522d6de417372a21e73ccca3ba > Signed-off-by: Arne Schwabe > --- > src/openvpn/route.c | 4 +++- > 1

Re: [Openvpn-devel] [PATCH 2/4] [CMake] Only add -Wno-stringop-truncation on supported compilers

2023-06-30 Thread Frank Lichtenheld
On Thu, Jun 29, 2023 at 11:56:08PM +0200, Arne Schwabe wrote: > The -Wno-stringop-truncation flag is only supported by some GCC versions > and not by Clang (macOS, FreeBSD) at all. > > Move the includes to the top the file to have them available when running > the check_c_compiler_flag.

Re: [Openvpn-devel] [PATCH 3/4] Check if the -wrap argument is actually supported by the platform's ld

2023-06-30 Thread Frank Lichtenheld
On Thu, Jun 29, 2023 at 11:56:10PM +0200, Arne Schwabe wrote: > This avoids build errors on macOS. Also the test_tls_crypt command works > just fine on FreeBSD with its linkers, so do not make that test Linux only. NAK. Breaks build on mingw. Will investigate why. Regards, -- Frank