[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-25 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [M] Change in openvpn[release/2.6]: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to relea...

2023-09-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/311?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by d12fk Change subject: vcpkg-ports/pkcs11-helper: Backport MinGW series from m

[Openvpn-devel] [M] Change in openvpn[release/2.6]: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to relea...

2023-09-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/311?usp=email ) Change subject: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6 .. vcpkg-ports/pkcs11-helper: Backport MinGW s

[Openvpn-devel] [PATCH applied] Re: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6

2023-09-25 Thread Gert Doering
This is one of the patches where "--whitespace=fix" will break the thing... but I've been here, so, hopefully nothing broken :-) Tested building on my Ubuntu/MinGW setup, and on the GHA builders, and all succeed. Your patch has been applied to the release/2.6 branch. commit cce957a5b6ed11b0fa35a

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt .. Mock openvpn_exece on win32 also for test_tls_crypt This function i

[Openvpn-devel] [PATCH applied] Re: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-25 Thread Gert Doering
"It does something", namely, build a pkt_testdriver-mock_win32_execve.o and link that to pkt_testdriver.exe (on my mingw test system). And I seem to remember that's all it intends to do - so the ...execve.o can be used by another test driver in one of the next patches. Your patch has been applied

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by d12fk Change subject: Mock openvpn_exece on win32 also for test_tls_crypt ...

[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6

2023-09-25 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 ..

[Openvpn-devel] [PATCH] Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-25 Thread Frank Lichtenheld
From: Arne Schwabe This function is needed to commpile on win32 as run_command.c defines it on Unix Linux but on windows it is defined in win32.c which pulls in too many other unresolvable symbols. Patch v2: Also add mock_win32_execve.c to automake files Change-Id: I8c8fe298eb30e211279f3fc01058