Re: [Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread Oma Comp.
remove me from your mailing list. Please чт, 19 окт. 2023 г. в 20:29, MaxF (Code Review) : > Attention is currently required from: flichtenheld, plaisthos. > > MaxF *uploaded patch set #6* to this change. > > View Change > > Add support for m

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#6). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#5). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 4: (1

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#4). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/372?usp=email to look at the new patch set (#5). Change subject: Update README.mbedtls ...

[Openvpn-devel] [PATCH] fix(ssl): init peer_id when init tls_multi

2023-10-19 Thread yatta
From: pushan <62173185+pusha...@users.noreply.github.com> When openvpn run in UDP server mode, if ssl connections reach the max clients, the next connection would be failed in `multi_create_instance` and the half connection will be close in `multi_close_instance`, which may lead array `m->insta

[Openvpn-devel] [S] Change in openvpn[master]: mss/mtu: make all size calculations use size_t

2023-10-19 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/269?usp=email ) Change subject: mss/mtu: make all size calculations use size_t .. mss/mtu: make all size calculations use size_t Half of them used unsigne

[Openvpn-devel] [S] Change in openvpn[master]: mss/mtu: make all size calculations use size_t

2023-10-19 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/269?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: mss/mtu: make all size calculations use size_t

[Openvpn-devel] [PATCH applied] Re: mss/mtu: make all size calculations use size_t

2023-10-19 Thread Gert Doering
Not a huge fan of size_t (8 bytes instead of 4 bytes for an unsigned int, on normal LP64 platforms), but this is all non-critical code, not stored and not in the packet forwarding path. So not NAKing an already-ACKed patch again... Smoke-tested locally and on GHA. Your patch has been applied to