Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-10 Thread Gert Doering
Hi, On Fri, Nov 10, 2023 at 10:51:34AM +0100, Gert Doering wrote: > I'll see if I can reproduce this case here and we'll fix it ASAP. We couldn't reproduce it yet, but we have a crash dump in GH issue #449, which hints at the commit cd4d819c99266 getting this double-extra-check wrong. So if you

[Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-10 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/425?usp=email ) Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR .

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Make --dns options apply for tap-windows6 driver

2023-11-10 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/423?usp=email ) Change subject: Make --dns options apply for tap-windows6 driver ...

[Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-10 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/425?usp=email ) Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR .

[Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/425?usp=email to review the following change. Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Make --dns options apply for tap-windows6 driver

2023-11-10 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos, stipa. Hello d12fk, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/423?usp=email to look at the new patch set (#2). Change subject: Make --dns options apply for tap-win

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn if pushed options require DHCP

2023-11-10 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/424?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed

[Openvpn-devel] [S] Change in openvpn[master]: Disable TLS 1.3 support with mbed TLS

2023-11-10 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/403?usp=email to review the following change. Change subject: Disable TLS 1.3 support with mbed TLS ..

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-10 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/402?usp=email to review the following change. Change subject: Enable key export with mbed TLS 3.x.y ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Make --dns options apply for tap-windows6 driver

2023-11-10 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/423?usp=email ) Change subject: Make --dns options apply for tap-windows6 driver ...

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn if pushed options require DHCP

2023-11-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/424?usp=email ) Change subject: Warn if pushed options require DHCP .. Patch Set

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn if pushed options require DHCP

2023-11-10 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/424?usp=email to review the following change. Change subject: Warn if pushed options require DHCP

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Make --dns options apply for tap-windows6 driver

2023-11-10 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/423?usp=email to review the following change. Change subject: Make --dns options apply for tap-windows6 driver

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-10 Thread Gert Doering
Hi, On Fri, Nov 10, 2023 at 12:25:22PM +0400, Dmitry Melekhov wrote: > btw, what I missed, openvpn dies: > > openvpn[11346]: segfault at 0 ip 55e33503f5f3 sp 7fff33642390 error > 4 in openvpn[55e334fc8000+8f000] > > but only  multipoint udp . This is bad (but very different from "it sto

Re: [Openvpn-devel] OpenVPN 2.6.7 released

2023-11-10 Thread Dmitry Melekhov
btw, what I missed, openvpn dies: openvpn[11346]: segfault at 0 ip 55e33503f5f3 sp 7fff33642390 error 4 in openvpn[55e334fc8000+8f000] but only  multipoint udp . 10.11.2023 11:35, Dmitry Melekhov пишет: 10.11.2023 11:23, Gert Doering пишет: Hi, On Fri, Nov 10, 2023 at 11:19:58AM