[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/456?usp=email ) Change subject: Extend the error message when TLS 1.0 PRF fails ..

[Openvpn-devel] [S] Change in openvpn[master]: Allow specifying custom mbed TLS directories with CMake

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email ) Change subject: Allow specifying custom mbed TLS directories with CMake

[Openvpn-devel] [S] Change in openvpn[master]: Fix building mbed TLS with CMake and allow specifying custom directories

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/377?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/455?usp=email ) Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

[Openvpn-devel] [S] Change in openvpn[master]: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/455?usp=email to look at the new patch set (#3). Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to review the following change. Change subject: Add test_ssl unit test and test export of PEM to file

[Openvpn-devel] [L] Change in openvpn[master]: Move tls_get_cipher_name_pair and get_num_elements to ssl_utils.c

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/470?usp=email to review the following change. Change subject: Move tls_get_cipher_name_pair and get_num_elements to ssl_utils.c

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Use mingw compile definition also to unit tests

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/469?usp=email to review the following change. Change subject: Use mingw compile definition also to unit tests

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-07 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass

2023-12-07 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

2023-12-07 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/456?usp=email ) Change subject: Extend the error message when TLS 1.0 PRF fails ..

[Openvpn-devel] [S] Change in openvpn[master]: Allow specifying custom mbed TLS directories with CMake

2023-12-07 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email ) Change subject: Allow specifying custom mbed TLS directories with CMake