[Openvpn-devel] [S] Change in openvpn[master]: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/455?usp=email ) Change subject: Cache mbed TLS dependency and build latest 2.x mbed TLS as well

[Openvpn-devel] [PATCH v1] unit_tests: remove includes for mock_msg.h

Not actually used. Change-Id: I5e394bb73702d87562ed354100eaff9b41f5389e Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master and release/2.6. Gerrit URL:

[Openvpn-devel] [PATCH v1] Move tls_get_cipher_name_pair and get_num_elements to ssl_utils.c

From: Arne Schwabe This allow these functions to be defined without having to include ssl.c/misc.c which pulls in a lot of more dependencies. Change-Id: I605394d4f3872a168d05bbbe52d90f6d48935865 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/475?usp=email to look at the new patch set (#2). Change subject: test_user_pass: add basic tests for static/dynamic challenges

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: Check fatal errors for empty username/password

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/474?usp=email to look at the new patch set (#2). Change subject: test_user_pass: Check fatal errors for empty username/password

[Openvpn-devel] [L] Change in openvpn[master]: Move tls_get_cipher_name_pair and get_num_elements to ssl_utils.c

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/470?usp=email ) Change subject: Move tls_get_cipher_name_pair and get_num_elements to ssl_utils.c

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) Change subject: Add test_ssl unit test and test export of PEM to file ..

[Openvpn-devel] [M] Change in openvpn[master]: misc: make get_auth_challenge static

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/476?usp=email to review the following change. Change subject: misc: make get_auth_challenge static

[Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=email to look at the new patch set (#3). Change subject: test_user_pass: new UT for get_user_pass

[Openvpn-devel] [S] Change in openvpn[master]: test_user_pass: Add UTs for character filtering

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/473?usp=email to review the following change. Change subject: test_user_pass: Add UTs for character filtering

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/475?usp=email to review the following change. Change subject: test_user_pass: add basic tests for static/dynamic challenges

[Openvpn-devel] [M] Change in openvpn[master]: buffer: add documentation for string_mod and extend related UT

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/472?usp=email to review the following change. Change subject: buffer: add documentation for string_mod and extend related UT

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: Check fatal errors for empty username/password

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/474?usp=email to review the following change. Change subject: test_user_pass: Check fatal errors for empty username/password

Re: [Openvpn-devel] Fail on odd number of hex digits in key files

Dear openvpn-devel, Please find an updated version that doesn't hide away the format string in a variable and is instead a string literal. Best, Reynir BjörnssonFrom d7de5af166b50ba6449cdbee58ad93a7d8b52fc7 Mon Sep 17 00:00:00 2001 In-Reply-To: References: From:

[Openvpn-devel] Fail on odd number of hex digits in key files

Dear openvpn-devel, Please find attached a patch that addresses the following bug: When a key file has an odd number of hex digits the last digit is silently ignored. This can easily be tested by adding an extra hex digit at the line before the footer; openvpn does not notice and will use the

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [XS] Change in openvpn[master]: Extend the error message when TLS 1.0 PRF fails

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/456?usp=email ) Change subject: Extend the error message when TLS 1.0 PRF fails ..