[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#2). Change subject: cmake: create and link compile_commands.jso

[Openvpn-devel] [XS] Change in openvpn[master]: create and (sym)link compile_commands.json file

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to review the following change. Change subject: create and (sym)link compile_commands.json file

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email to review the following change. Change subject: cmake: build native binaries with debug info ...

[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email ) Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set