[Openvpn-devel] [PATCH applied] Re: cmake: create and link compile_commands.json file

2023-12-20 Thread Gert Doering
Since this is build system (-only) and won't affected generated code, I have not tested it. I have an ACK, and the buildbots are happy with it. Your patch has been applied to the master branch. commit 855030f3d76324bdb614c05ec0ca5b86d66653bb Author: Heiko Hund Date: Wed Dec 20 13:36:59 2023 +0

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-20 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/483?usp=email ) Change subject: cmake: create and link compile_commands.json file .. cmake: create and link compile_commands.json file CMake has support t

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-20 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/483?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: cmake: create and link compile_commands.json file .

[Openvpn-devel] [M] Change in openvpn[master]: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs

2023-12-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/457?usp=email ) Change subject: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs ..

Re: [Openvpn-devel] [PATCH v2] tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-20 Thread Frank Lichtenheld
On Wed, Dec 20, 2023 at 02:36:37PM +0100, Frank Lichtenheld wrote: > From: Lev Stipakov > > Commits > > 1c4a47f7 ("wintun: set adapter properties via interactive service") > 18826de5 ("Set WINS servers via interactice service") > > added functionality of add/remove DNS/WINS via interact

[Openvpn-devel] [PATCH v2] tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-20 Thread Frank Lichtenheld
From: Lev Stipakov Commits 1c4a47f7 ("wintun: set adapter properties via interactive service") 18826de5 ("Set WINS servers via interactice service") added functionality of add/remove DNS/WINS via interactive service, which is used mostly by dco-win and wintun (tap-windows6 normally uses

[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-20 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email ) Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set

[Openvpn-devel] IRC community meeting summary

2023-12-20 Thread Johan Draaisma
Meeting summary for 20 December 2023: * *New: no meeting on 27th december or 3 january.* /Normal meetings to resume on January 10 2024./ * *Updated: OpenVPN 2.6.9 release* /Given that we're so close to end of year, we'll push this to next year./ /The --tls-export-cert PR needs a li

[Openvpn-devel] [PATCH v4] cmake: create and link compile_commands.json file

2023-12-20 Thread Frank Lichtenheld
From: Heiko Hund CMake has support to create a json file which contains exact information how each file in the project is compiled. This file can be consumed by clangd, which in turn provides precise symbol information to IDEs for better code navigation and contextual information. I use it with

[Openvpn-devel] [S] Change in openvpn[master]: Use mingw compile definition also to unit tests

2023-12-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/469?usp=email ) Change subject: Use mingw compile definition also to unit tests .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-20 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-20 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/483?usp=email ) Change subject: cmake: create and link compile_commands.json file .