[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2024-01-01 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2024-01-01 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=email to look at the new patch set (#8). Change subject: Check PRF availability on initialisation and add

[Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate...

2024-01-01 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/460?usp=email ) Change subject: Check PRF availability on initialisation and add --force-tls-key-material-export

[Openvpn-devel] [PATCH applied] Re: get_default_gateway() HWADDR overhaul

2024-01-01 Thread Gert Doering
Patch has been applied to the master and release/2.6 branch (I did apply the "other" get_default_gateway() patch because it was clearly a bugfix for the undefined behaviour on MacOS, and I think this is the better bugfix, so, 2.6 as well). Have not explicitly tested this again, but fed it to GHA

[Openvpn-devel] [PATCH applied] Re: OpenBSD: repair --show-gateway

2024-01-01 Thread Gert Doering
Patch has been applied to the master and release/2.6 branch (bugfix). commit acf6f33987c72d9151f68eb618bbaf2d10e61877 (master) commit 77376fc5cf6235493bff78794c9c6589e3f710ad (release/2.6) Author: Gert Doering Date: Mon Jan 1 10:40:54 2024 +0100 OpenBSD: repair --show-gateway

Re: [Openvpn-devel] [PATCH] OpenBSD: repair --show-gateway

2024-01-01 Thread Arne Schwabe
Am 01.01.24 um 10:40 schrieb Gert Doering: OpenBSD route sockets do not want to be passed RTA_IFP on RTM_GET - if we do this, we get back EINVAL. On other platforms, if we do not request RTA_IFP, we will not get back interface information for queried routes - on OpenBSD, RTA_IFP comes back

Re: [Openvpn-devel] [PATCH] get_default_gateway() HWADDR overhaul

2024-01-01 Thread Arne Schwabe
Am 01.01.24 um 10:27 schrieb Gert Doering: commit f13331005d5a7 (gerrit/454) most painfully works around the limitations of the SIOCGIFCONF API, with struct member access on an unaligned buffer, possibly overrunning sockaddr structures, etc. - and the result still did not work on OpenSolaris and

[Openvpn-devel] [PATCH] OpenBSD: repair --show-gateway

2024-01-01 Thread Gert Doering
OpenBSD route sockets do not want to be passed RTA_IFP on RTM_GET - if we do this, we get back EINVAL. On other platforms, if we do not request RTA_IFP, we will not get back interface information for queried routes - on OpenBSD, RTA_IFP comes back always... So we need to #ifdef this, RTA_IFP on

[Openvpn-devel] [PATCH] get_default_gateway() HWADDR overhaul

2024-01-01 Thread Gert Doering
commit f13331005d5a7 (gerrit/454) most painfully works around the limitations of the SIOCGIFCONF API, with struct member access on an unaligned buffer, possibly overrunning sockaddr structures, etc. - and the result still did not work on OpenSolaris and OpenBSD (no AF_LINK in the returned

Re: [Openvpn-devel] [PATCH] OpenSolaris: teach get_default_gateway() to get HWADDR

2024-01-01 Thread Gert Doering
Hi, On Sun, Dec 31, 2023 at 06:41:51PM +0100, Gert Doering wrote: > In the context of gerrit/454 it was uncovered that the existing > code never worked on OpenSolaris anyway because no AF_LINK > addresses are returned. Debugging this, it was found that > SIOCGIFHWADDR exists instead, and "man