[Openvpn-devel] [M] Change in openvpn[master]: Keep exported certificate files for following calls

2024-01-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/487?usp=email ) Change subject: Keep exported certificate files for following calls ...

[Openvpn-devel] [M] Change in openvpn[master]: Allow having an extra function that is called when an env is freed

2024-01-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/486?usp=email ) Change subject: Allow having an extra function that is called when an env is freed ...

[Openvpn-devel] [M] Change in openvpn[master]: cmake: symlink whole build dir not just .json file

2024-01-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/501?usp=email to review the following change. Change subject: cmake: symlink whole build dir not just .json fi

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#10) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Add test_ssl unit test and test export of PEM to file ...

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) Change subject: Add test_ssl unit test and test export of PEM to file .. Add test_ssl unit test and test export of PEM to file This introd

[Openvpn-devel] [PATCH applied] Re: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread Gert Doering
After some long haggling with cmake and autoconf and mingw... finally it builds & tests everywhere. Verified on a local mingw+autoconf build and with GHA. Your patch has been applied to the master branch. It can not go to release/2.6 "as is", as it would need the "win_get_tmpdir" patch to build

[Openvpn-devel] [PATCH v9] Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread Gert Doering
From: Arne Schwabe This introduces a number of mock function to be able to compile ssl_verify_*.c and ssl_mbedtls.c/ssl_openssl.c into a unit and adds quite a number of files to that unit. But it allows similar unit tests (in term of dependencies) to be added in the future. Change-Id: Ie248d35d0

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) Change subject: Add test_ssl unit test and test export of PEM to file .

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to look at the new patch set (#9). Change subject: Add test_ssl unit test and test export o

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to look at the new patch set (#8). Change subject: Add test_ssl unit test and test export o

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to look at the new patch set (#7). Change subject: Add test_ssl unit test and test export o

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Co

[Openvpn-devel] [S] Change in openvpn[master]: Use mingw compile definition also to unit tests

2024-01-16 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/469?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Use mingw compile definition also to unit tests ...

[Openvpn-devel] [S] Change in openvpn[master]: Use mingw compile definition also to unit tests

2024-01-16 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/469?usp=email ) Change subject: Use mingw compile definition also to unit tests .. Use mingw compile definition also to unit tests Currently we only apply

[Openvpn-devel] [PATCH applied] Re: Use mingw compile definition also to unit tests

2024-01-16 Thread Gert Doering
Your patch has been applied to the master branch. (At some point we will want to collect all buildsystem-related improvements again and backport/cheery-pick to release/2.6) commit 0ce06893912830fa2044c5d6a62e666afd4a (master) Author: Arne Schwabe Date: Tue Jan 16 14:18:31 2024 +0100 U

[Openvpn-devel] [PATCH v4] Use mingw compile definition also to unit tests

2024-01-16 Thread Gert Doering
From: Arne Schwabe Currently we only apply the defines for windows APIs and Unicode to OpenVPN itself. We should rather treat the unit tests the same as our main binary to reduce potential differences. Change-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b Signed-off-by: Arne Schwabe Acked-by: Fr

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-16 Thread cron2 (Code Review)
Attention is currently required from: plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/471?usp=email ) Change subject: Add test_ssl unit test and test export of PEM to file .. Patch

[Openvpn-devel] [PATCH applied] Re: Implement the --tls-export-cert feature

2024-01-16 Thread Gert Doering
Tested a few times. Single difference between v11 and v12 is that it no longer calls unlink(NULL) for "no cert file created" - GHA found that. All the rest is as fine as it was in v11, and a reasonable re-implementation of the code removed due to the relicensing project. Your patch has been appl

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2024-01-16 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Implement the --tls-export-cert feature This is a re-implementation of the --tl

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2024-01-16 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#13) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Implement the --tls-export-cert feature .

[Openvpn-devel] [PATCH v12] Implement the --tls-export-cert feature

2024-01-16 Thread Gert Doering
From: Arne Schwabe This is a re-implementation of the --tls-export-cert feature. This was necessary to due to missing approval to re-license the old (now removed) code. The re-implementation is based on the following description of the feature provided by David: Add an option to export certifi

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2024-01-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch