[Openvpn-devel] [S] Change in openvpn[master]: NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/500?usp=email ) Change subject: NTLM: when NTLMv1 is requested, try NTLMv2 instead .. NTLM: when NTLMv1 is requested, try NTLMv2 instead Commit

[Openvpn-devel] [S] Change in openvpn[master]: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/498?usp=email ) Change subject: proxy-options.rst: Add proper documentation for --http-proxy-user-pass .. proxy-options.rst: Add proper documentation for

[Openvpn-devel] [PATCH applied] Re: NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread Gert Doering
This is "master only", as it is based on the NTLMv1 removal. Haven't tested it beyond "GHA is happy" and "the code change looks reasonable and matches what the commit message says". Your patch has been applied to the master branch. commit b541a86948d7e9866b33e876fcf070fad00b3dce Author: Frank

[Openvpn-devel] [S] Change in openvpn[master]: NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/500?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: NTLM: when NTLMv1 is requested, try NTLMv2 instead

[Openvpn-devel] [S] Change in openvpn[master]: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/498?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: proxy-options.rst: Add proper documentation for

[Openvpn-devel] [PATCH applied] Re: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread Gert Doering
Your patch has been applied to the master and release/2.6 branch (docs). (2.6 needed conflict resultion because of the "NTLMv1 has been removed" line) commit d3f84afedd33734416704d5d92e8d3ac639ef491 (master) commit 7b1f2009ce9670e2e0ffea0c01b1c4922a2d4369 (release/2.6) Author: Frank Lichtenheld

[Openvpn-devel] [PATCH v1] proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread Gert Doering
From: Frank Lichtenheld And extend examples section for authenticated HTTP proxies because is was misleading. Change-Id: I7a754d0b4a76a9227bf922f65176cd9ec4d7670c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one

[Openvpn-devel] [S] Change in openvpn[master]: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/498?usp=email ) Change subject: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

[Openvpn-devel] [PATCH v1] NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread Gert Doering
From: Frank Lichtenheld Commit 21910ebc2ee8a6138eb2af8d38056d2b94e59f9c removed support for NTLMv1 authentication. This adjusts the behavior for existing configurations that specify "ntlm" keyword. Do not error out hard, instead just try to upgrade. This should work fine in many cases and will

[Openvpn-devel] [XS] Change in openvpn[master]: Remove conditional text for Apache2 linking exception

2024-01-18 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/502?usp=email ) Change subject: Remove conditional text for Apache2 linking exception .. Remove conditional text for Apache2 linking exception With the

[Openvpn-devel] [XS] Change in openvpn[master]: Remove conditional text for Apache2 linking exception

2024-01-18 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/502?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by dazo Change subject: Remove conditional text for Apache2 linking exception

[Openvpn-devel] [PATCH applied] Re: Remove conditional text for Apache2 linking exception

2024-01-18 Thread Gert Doering
This concludes the changing of our license wrt the Apache2 exception - it was quite a journey... :-) Your patch has been applied to the master and release/2.6 branch. commit 275aa892c30e91adfec9276f6d6845756b141c62 (master) commit 20bc8bd5af9d1ee0489d0ee58ae9c2c2f9b0cf9f (release/2.6) Author:

[Openvpn-devel] [PATCH v1] Remove conditional text for Apache2 linking exception

2024-01-18 Thread Gert Doering
From: Arne Schwabe With the reimplementation of the tls-export feature and removal/approval or being trivial of the rest of the code, now all the code falls under new license. Remove the conditional text of the license to be only valid for parts of OpenVPN. Change-Id:

[Openvpn-devel] [XS] Change in openvpn[master]: Remove conditional text for Apache2 linking exception

2024-01-18 Thread dazo (Code Review)
Attention is currently required from: flichtenheld, plaisthos. dazo has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/502?usp=email ) Change subject: Remove conditional text for Apache2 linking exception

[Openvpn-devel] [S] Change in openvpn[master]: NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/500?usp=email ) Change subject: NTLM: when NTLMv1 is requested, try NTLMv2 instead ..

[Openvpn-devel] [XS] Change in openvpn[master]: Remove conditional text for Apache2 linking exception

2024-01-18 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/502?usp=email to review the following change. Change subject: Remove conditional text for Apache2 linking exception

[Openvpn-devel] [L] Change in openvpn[release/2.6]: Backport mbed TLS 3 support to OpenVPN 2.6

2024-01-18 Thread plaisthos (Code Review)
plaisthos has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/404?usp=email ) Change subject: Backport mbed TLS 3 support to OpenVPN 2.6 .. Abandoned Cherry picked as individiual commits. -- To view, visit