[Openvpn-devel] [M] Change in openvpn[master]: Add unit test for encrypting/decrypting data channel

2024-02-08 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/505?usp=email ) Change subject: Add unit test for encrypting/decrypting data channel .. Add unit test for encrypting/decrypting data channel This test is

[Openvpn-devel] [M] Change in openvpn[master]: Add unit test for encrypting/decrypting data channel

2024-02-08 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/505?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Add unit test for encrypting/decrypting data

[Openvpn-devel] [PATCH applied] Re: Add unit test for encrypting/decrypting data channel

2024-02-08 Thread Gert Doering
Extracting the old test approach out to unit tests is generally a good thing. Plus, it has an ACK :-) - tested locally and via GHA. Your patch has been applied to the master branch. commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 Author: Arne Schwabe Date: Thu Feb 8 09:57:49 2024 +0100

[Openvpn-devel] [PATCH v3] Add unit test for encrypting/decrypting data channel

2024-02-08 Thread Gert Doering
From: Arne Schwabe This test is reusing code from --test-crypto but is modified to not rely on the static key functionality and also only tests the most common algorithm. So it does not yet completely replace --test-crypto Change-Id: Ifa5ae96165d17b3cae4afc53e844bb34d1610e58 Acked-by: Frank

[Openvpn-devel] [PATCH applied] Re: test_user_pass: add basic tests for static/dynamic challenges

2024-02-08 Thread Gert Doering
Tested on a local build and via GHA. Passes :-) Your patch has been applied to the master branch. commit ca122f990c76090ba90159812e89049810710bfe Author: Frank Lichtenheld Date: Wed Feb 7 18:12:39 2024 +0100 test_user_pass: add basic tests for static/dynamic challenges

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges

2024-02-08 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#9) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/475?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: test_user_pass: add basic tests for static/dynamic

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges

2024-02-08 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/475?usp=email ) Change subject: test_user_pass: add basic tests for static/dynamic challenges .. test_user_pass: add basic tests for static/dynamic