[Openvpn-devel] OpenVPN 3 Linux v22_dev released

2024-06-20 Thread David Sommerseth via Openvpn-devel
OpenVPN 3 Linux v22_dev (Limited Release) This is a limited release primarily targeting Fedora 39 and newer plus Ubuntu 24.04. Other Linux distributions shipping glib2 version 2.76 or newer will also benefit from this release. This release contains a massive re-factoring of the D-Bus integrat

[Openvpn-devel] [S] Change in openvpn[master]: console_systemd: rename query_user_exec to query_user_systemd

2024-06-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/670?usp=email to review the following change. Change subject: console_systemd: rename query_user_exec to query_user_systemd ..

[Openvpn-devel] [M] Change in openvpn[master]: t_server_null: multiple improvements and fixes

2024-06-20 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/669?usp=email to review the following change. Change subject: t_server_null: multiple improvements and fixes .

[Openvpn-devel] [S] Change in openvpn[master]: configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/667?usp=email ) Change subject: configure: Add -Wstrict-prototypes and -Wold-style-definition .. configure: Add -Wstrict-prototypes and -Wold-style-definit

[Openvpn-devel] [S] Change in openvpn[master]: configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/667?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: configure: Add -Wstrict-prototypes and -Wold-style-defi

[Openvpn-devel] [PATCH applied] Re: configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread Gert Doering
"Because it makes sense" - we try to keep our style consistent and clean, and this will ensure we'll notice new commits with func() instead of func(void) prototypes. Plus fixing the inconsistencies we already had. The buildbots and GH say "this works on all supported platforms", so in it goes. Y

[Openvpn-devel] [S] Change in openvpn[master]: configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/667?usp=email ) Change subject: configure: Add -Wstrict-prototypes and -Wold-style-definition .

[Openvpn-devel] [PATCH v4] configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread Gert Doering
From: Frank Lichtenheld These are not covered by -Wall (nor -Wextra) but we want to enforce them. Change-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I reque

[Openvpn-devel] [S] Change in openvpn[master]: configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/667?usp=email to look at the new patch set (#4). Change subject: configure: Add -Wstrict-prototypes and -Wol

[Openvpn-devel] [S] Change in openvpn[master]: configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/667?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [PATCH v2] configure: Add -Wstrict-prototypes and -Wold-style-definition

2024-06-20 Thread Gert Doering
From: Frank Lichtenheld These are not covered by -Wall (nor -Wextra) but we want to enforce them. Change-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I reque

[Openvpn-devel] [XS] Change in openvpn[master]: t_server_null.sh: Fix failure case

2024-06-20 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/668?usp=email ) Change subject: t_server_null.sh: Fix failure case .. t_server_null.sh: Fix failure case The changes for POSIX shell compatibility and par

[Openvpn-devel] [PATCH applied] Re: t_server_null.sh: Fix failure case

2024-06-20 Thread Gert Doering
Yeah, obvious in hindsight :-) Your patch has been applied to the master branch. commit c9f29e35cd475f18c34aa96eb5fad452210404f9 Author: Frank Lichtenheld Date: Thu Jun 20 12:37:48 2024 +0200 t_server_null.sh: Fix failure case Signed-off-by: Frank Lichtenheld Acked-by: Samuli

[Openvpn-devel] [XS] Change in openvpn[master]: t_server_null.sh: Fix failure case

2024-06-20 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/668?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by mattock Change subject: t_server_null.sh: Fix failure case ..

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-06-20 Thread its_Giaan (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email to look at the new patch set (#10). Change subject: Http-proxy: fix bug preventi

[Openvpn-devel] [PATCH v1] t_server_null.sh: Fix failure case

2024-06-20 Thread Gert Doering
From: Frank Lichtenheld The changes for POSIX shell compatibility and parallel make compatibility broke actually failing the test when a subtest fails. Change-Id: I35f7cf84e035bc793d6f0f59e46edf1a2efe0391 Signed-off-by: Frank Lichtenheld Acked-by: Samuli Seppänen --- This change was reviewed

[Openvpn-devel] [PATCH applied] Re: interactive.c: Improve access control for gui<->service pipe

2024-06-20 Thread Gert Doering
Indeed, the patch differs only in a single line, related to the snprintf() cleanup (which is only in master). Thanks, Lev, and Selva. Stared at code differences (fine) and test compiled via GHA and local ubuntu/mingw - all good. Your patch has been applied to the master branch. commit babf312ee