[Openvpn-devel] [S] Change in openvpn[master]: Refuse clients if username or password is > USER_PASS_LEN

2024-10-25 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/787?usp=email to review the following change. Change subject: Refuse clients if username or password is > USER_PASS_LEN

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: use wait instead of marker files

2024-10-25 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/786?usp=email to review the following change. Change subject: t_server_null: use wait instead of marker files

[Openvpn-devel] [PATCH applied] Re: t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread Gert Doering
Tested this quite extensively up to v9 ;-) - by intentionally making openvpn server misbehave (ignoring first 2 signals sent to it) with this patch --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3864,6 +3864,10 @@ multi_push_restart_schedule_exit(struct multi_context *m, bool next_server

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/775?usp=email ) Change subject: t_server_null: forcibly kill misbehaving servers .. t_server_null: forcibly kill misbehaving servers Change-Id: Ic0f98cd3b

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#10) to the change originally created by mattock. ( http://gerrit.openvpn.net/c/openvpn/+/775?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: t_server_null: forcibly kill misbehaving servers ..

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/775?usp=email ) Change subject: t_server_null: forcibly kill misbehaving servers .

[Openvpn-devel] [PATCH v9] t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread Gert Doering
From: Samuli Seppänen Change-Id: Ic0f98cd3b87a7b86e032e63167ac9036f7c08fcb Signed-off-by: Samuli Seppänen Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/7

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/775?usp=email to look at the new patch set (#9). Change subject: t_server_null: forcibly kil

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: forcibly kill misbehaving servers

2024-10-25 Thread cron2 (Code Review)
er_null_server-1194_udp with pid 23977! Tail of server log: tail: t_server_null-fbsd14bb.ov.greenie.net-20241025-105632/t_server_null_server-1194_udp.log: Permission denied ERROR: had to send SIGKILL to server t_server_null_server-1195_tcp with pid 23983! Tail of server log: tail: t_server_null-

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: persist test log files

2024-10-25 Thread mattock (Code Review)
Attention is currently required from: cron2, flichtenheld, mattock, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/776?usp=email to look at the new patch set (#2). The following approvals got outdated

[Openvpn-devel] [PATCH v2] t_server_null: persist test log files

2024-10-25 Thread Gert Doering
From: Samuli Seppänen The goal is to help debug issues with t_server_null. The immediate goal is to be able to debug server startup issues encountered on some of the *BSD platforms. Change-Id: I49f1e7d25edb62bf202ffceb45dedc213f2eafdd Signed-off-by: Samuli Seppänen Acked-by: Gert Doering ---

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: persist test log files

2024-10-25 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/776?usp=email ) Change subject: t_server_null: persist test log files ..