[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [S] Change in openvpn[master]: [TEST-ONLY] Mess with internal logic to test epoch data

2024-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/818?usp=email to review the following change. Change subject: [TEST-ONLY] Mess with internal logic to test epoch data ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement methods to generate and manage OpenVPN Epoch keys

2024-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/804?usp=email to look at the new patch set (#5). Change subject: Implement methods to generate and manage OpenVPN Epoch keys

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-22 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. Hello MaxF, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/798?usp=email to look at the new patch set (#5). Change subject: Implement HKDF expand function based on RFC 8446

[Openvpn-devel] [L] Change in openvpn[master]: Implement epoch key data format

2024-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email to look at the new patch set (#5). Change subject: Implement epoch key data format

[Openvpn-devel] [S] Change in openvpn[master]: Add small unit test for buf_chomp

2024-11-22 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/817?usp=email to review the following change. Change subject: Add small unit test for buf_chomp

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: enable mode server on supported configuration

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email ) Change subject: dco-win: factor out getting dco version ..

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/733?usp=email to look at the new patch set (#4). The following approvals got outdated an

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email to look at the new patch set (#2). Change subject: mudp.c: keep offset value when resetting bu

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email to look at the new patch set (#3). Change subject: dco-win: multipeer support

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email ) Change subject: dco-win: multipeer support .. Patch Set 2: (2 co

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplify do_close_link_socket()

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/813?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when reset buffer

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when reset buffer .. Pa

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when resetting buffer ..

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: enable mode server on supported configuration

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/812?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplity do_close_link_socket()

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/813?usp=email ) Change subject: dco-win: simplity do_close_link_socket() .. Patch Set 1: (1 co

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable DCO for server mode and unsupported driver version

2024-11-22 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: disable DCO for server mode and unsupported driver version ..

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2024-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email ) Change subject: dco-win: multipeer support .. Patch Set 1: (2 co

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when reset buffer

2024-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when reset buffer .. Pa

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplity do_close_link_socket()

2024-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/813?usp=email ) Change subject: dco-win: simplity do_close_link_socket() .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable DCO for server mode and unsupported driver version

2024-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/812?usp=email ) Change subject: dco-win: disable DCO for server mode and unsupported driver version ..

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: factor out getting dco version

2024-11-22 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/733?usp=email ) Change subject: dco-win: factor out getting dco version ..