[Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null

2024-12-09 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, mattock, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email to look at the new patch set (#4). Change subject: Add lwip support to t_server_null

[Openvpn-devel] [PATCH v8] Use XOR instead of concatenation for calculation of IV from implicit IV

2024-12-09 Thread Gert Doering
From: Arne Schwabe This change prepares the extended packet id data where also the packet id part of the IV will be derived using xor. Using xor also in the AEAD case where this degenerates to a concatenation allows using the same IV generation code later. Change-Id: I74216d776d3e0a8dc987ec7b16

[Openvpn-devel] [S] Change in openvpn[master]: Fix memory leak in ntlm_support

2024-12-09 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/826?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by stipa Change subject: Fix memory leak in ntlm_support ...

[Openvpn-devel] [S] Change in openvpn[master]: Fix memory leak in ntlm_support

2024-12-09 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/826?usp=email ) Change subject: Fix memory leak in ntlm_support .. Fix memory leak in ntlm_support Not really important but prevents running the NTLM t_cl

[Openvpn-devel] [PATCH applied] Re: Fix memory leak in ntlm_support

2024-12-09 Thread Gert Doering
Haven't really tested but looks reasonable and still works as expected on the OpenSSL test instance here. Your patch has been applied to the master branch. commit ae82631be17ca8c49d356510c9e7709ddcf19db3 Author: Frank Lichtenheld Date: Mon Dec 9 20:49:57 2024 +0100 Fix memory leak in ntlm

[Openvpn-devel] [PATCH v1] Fix memory leak in ntlm_support

2024-12-09 Thread Gert Doering
From: Frank Lichtenheld Not really important but prevents running the NTLM t_client tests with ASAN enabled. Change-Id: If472398d4ff8323de485f084a07160b365dfc501 Signed-off-by: Frank Lichtenheld Acked-by: Lev Stipakov --- This change was reviewed on Gerrit and approved by at least one develop

[Openvpn-devel] [S] Change in openvpn[master]: Fix memory leak in ntlm_support

2024-12-09 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/826?usp=email ) Change subject: Fix memory leak in ntlm_support .. Patch Set 1: C

[Openvpn-devel] [S] Change in openvpn[master]: Fix memory leak in ntlm_support

2024-12-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/826?usp=email to review the following change. Change subject: Fix memory leak in ntlm_support

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

2024-12-09 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email ) Change subject: Use XOR instead of concatenation for calculation of IV from implicit IV

Re: [Openvpn-devel] SystemD user names

2024-12-09 Thread David Sommerseth via Openvpn-devel
On 06/12/2024 10:29, Marc Leeman wrote: David, cf. att. Thanks a lot! Patch has been committed. commit 9a1cf3fae9fb3788e9714d148d9b7efcb5f4c948 Author: Marc Leeman Date: Fri Dec 6 10:29:19 2024 +0100 build: Fix incorrect OPENVPN_USERNAME in D-Bus autostart files Remove hard c

Re: [Openvpn-devel] spelling errors

2024-12-09 Thread David Sommerseth via Openvpn-devel
On 06/12/2024 10:35, Marc Leeman wrote: FYI While preparing a package for debian, lintian complained about some spelling errors. I had a quick look, but since some are signals (e.g. succeded), I didn't want to meddle with them atm. I: openvpn3-client: spelling-error-in-binary Configration Confi

[Openvpn-devel] OpenVPN 3 Linux v24 released

2024-12-09 Thread David Sommerseth via Openvpn-devel
OpenVPN 3 Linux v24 (Stable release) The v24 release is another stable release. This resolves issues reported in several earlier releases and improves OpenVPN 3 Linux in several areas. * Improvement: Add --dns option support DNS resolver settings has been troublesome for many years, since

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-09 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-09 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-09 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/825?usp=email ) Change subject: dns: do not use netsh to set name server addresses .